Skip to content

Conversation

@Johan-Liebert1
Copy link
Member

Copy link
Contributor

@yasminvalim yasminvalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@HuijingHei
Copy link
Member

IMU, before merging this, make sure

@aaradhak aaradhak changed the title denylist: Remove ext.config.shared.kdump.crash NO-JIRA: denylist: Remove ext.config.shared.kdump.crash Nov 3, 2025
@openshift-ci-robot
Copy link

@Johan-Liebert1: This pull request explicitly references no jira issue.

In response to this:

https://gitlab.com/redhat/rhel/rpms/rust-afterburn/-/merge_requests/21 should fix this issue

Closes: #70

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@aaradhak
Copy link
Member

aaradhak commented Nov 3, 2025

/retest

1 similar comment
@HuijingHei
Copy link
Member

/retest

@Johan-Liebert1
Copy link
Member Author

Johan-Liebert1 commented Nov 4, 2025

Postprocess script 1

sed -i '/^ExecStart=\/usr\/sbin\/mpathconf --enable$/,${s//ExecStart=\/usr\/sbin\/mpathconf --enable --user_friendly_names n/;b};$q1' /usr/lib/dracut/modules.d/90multipath/multipathd-configure.service

failed, as sed did not have anything to change in
https://github.com/dracut-ng/dracut-ng/blob/13c5e5feee9ba86b960d351f87aa0eb25f242ff0/modules.d/70multipath/multipathd-configure.service#L18

Maybe the script could be updated to first check if we want to make a change in the file or not?

@HuijingHei
Copy link
Member

Postprocess script 1

sed -i '/^ExecStart=\/usr\/sbin\/mpathconf --enable$/,${s//ExecStart=\/usr\/sbin\/mpathconf --enable --user_friendly_names n/;b};$q1' /usr/lib/dracut/modules.d/90multipath/multipathd-configure.service

failed, as sed did not have anything to change in https://github.com/dracut-ng/dracut-ng/blob/13c5e5feee9ba86b960d351f87aa0eb25f242ff0/modules.d/70multipath/multipathd-configure.service#L18

Maybe the script could be updated to first check if we want to make a change in the file or not?

I think we should remove that, would you like to create a PR for that?

@Johan-Liebert1
Copy link
Member Author

Created a PR removing the script #90

@joelcapitao
Copy link
Member

/test rhcos-9-build-test-qemu

@joelcapitao
Copy link
Member

/test rhcos-9-build-test-metal

@Johan-Liebert1
Copy link
Member Author

/retest scos-9-build-test-metal

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 6, 2025

@Johan-Liebert1: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

/test images
/test rhcos-10-build-test-metal
/test rhcos-10-build-test-qemu
/test rhcos-9-build-test-metal
/test rhcos-9-build-test-qemu
/test rhcos-9next-build-test-metal
/test rhcos-9next-build-test-qemu
/test scos-10-build-test-metal
/test scos-10-build-test-qemu
/test scos-9-build-test-metal
/test scos-9-build-test-qemu
/test validate

Use /test all to run all jobs.

In response to this:

/retest scos-9-build-test-metal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Johan-Liebert1
Copy link
Member Author

/retest

@HuijingHei
Copy link
Member

coreos/coreos-assembler#4362 will fix the failed scos-10.

@HuijingHei
Copy link
Member

/test scos-10-build-test-qemu

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aaradhak, HuijingHei, jbtrystram, Johan-Liebert1, yasminvalim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [HuijingHei,aaradhak,jbtrystram,yasminvalim]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dustymabe
Copy link
Member

/retest

@HuijingHei
Copy link
Member

/test scos-10-build-test-qemu

@openshift-merge-bot openshift-merge-bot bot merged commit 72cfd33 into coreos:main Nov 7, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[rhcos9] test ext.config.shared.kdump.crash failed

8 participants