Merge pull request #2926 from dpfaffenbauer/fix/symfony

[CoreBundle] fix deprecation and issue in ObjectUserProvider and use stable Pimcore 12

Author: dpfaffenbauer

composer.json

@@ -174,7 +174,6 @@
     "symfony-tests-dir": "tests",
     "symfony-assets-install": "relative"
   },
-  "minimum-stability": "dev",
   "prefer-stable": true,
   "config": {
     "sort-packages": true,

src/CoreShop/Bundle/CoreBundle/Security/ObjectUserProvider.php

@@ -31,11 +31,6 @@ public function __construct(
     ) {
     }
 
-    public function loadUserByUsername(string $username): ?UserInterface
-    {
-        return $this->loadUserByIdentifier($username);
-    }
-
     public function loadUserByIdentifier(string $identifier): UserInterface
     {
         $user = $this->userRepository->findByLoginIdentifier($identifier);
@@ -47,7 +42,7 @@ public function loadUserByIdentifier(string $identifier): UserInterface
         throw new UserNotFoundException(sprintf('User with email address or username "%s" was not found', $identifier));
     }
 
-    public function refreshUser(UserInterface $user): ?UserInterface
+    public function refreshUser(UserInterface $user): UserInterface
     {
         if (!$user instanceof \CoreShop\Component\Core\Model\UserInterface) {
             throw new UnsupportedUserException();