Skip to content

Commit dbfac39

Browse files
refactor: Use for-of loops instead of traditional for loops
Address code review feedback to use for-of loops for simpler iteration over data.records arrays in both onNodeOver and onNodeDrop handlers. Co-authored-by: dpfaffenbauer <5981845+dpfaffenbauer@users.noreply.github.com>
1 parent 1f01b82 commit dbfac39

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/CoreShop/Bundle/ResourceBundle/Resources/public/pimcore/js/object/objectMultihref.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -156,8 +156,8 @@ coreshop.object.objectMultihref = Class.create(pimcore.object.tags.manyToManyObj
156156
var fromTree = this.isFromTree(ddSource);
157157

158158
// Check if any of the records can be dropped
159-
for (var i = 0; i < data.records.length; i++) {
160-
var recordData = data.records[i].data;
159+
for (var record of data.records) {
160+
var recordData = record.data;
161161
if (recordData.elementType === 'object' && this.dndAllowed(recordData, fromTree)) {
162162
return Ext.dd.DropZone.prototype.dropAllowed;
163163
}
@@ -176,8 +176,8 @@ coreshop.object.objectMultihref = Class.create(pimcore.object.tags.manyToManyObj
176176
var addedAny = false;
177177

178178
// Process all records in the drag selection
179-
for (var i = 0; i < data.records.length; i++) {
180-
var recordData = data.records[i].data;
179+
for (var record of data.records) {
180+
var recordData = record.data;
181181

182182
if (recordData.elementType !== 'object') {
183183
continue;

0 commit comments

Comments
 (0)