Remove logging and simplify error response in renderAction methods

Address review feedback to remove logging calls and simplify error responses
while still preventing information exposure.

Co-authored-by: dpfaffenbauer <5981845+dpfaffenbauer@users.noreply.github.com>

Author: Copilot

src/CoreShop/Bundle/OrderBundle/Controller/OrderInvoiceController.php

@@ -36,7 +36,6 @@
 use CoreShop\Component\Pimcore\DataObject\NoteServiceInterface;
 use CoreShop\Component\Resource\Factory\FactoryInterface;
 use CoreShop\Component\Resource\Factory\PimcoreFactoryInterface;
-use Psr\Log\LoggerInterface;
 use Symfony\Component\DependencyInjection\Attribute\Autowire;
 use Symfony\Component\EventDispatcher\GenericEvent;
 use Symfony\Component\HttpFoundation\JsonResponse;
@@ -188,18 +187,7 @@ public function renderAction(Request $request): Response
                     'Content-Disposition' => 'inline; filename="invoice-' . $invoice->getId() . '.pdf"',
                 ];
             } catch (\Exception $e) {
-                $this->container->get(LoggerInterface::class)->error(
-                    'Failed to render invoice PDF',
-                    [
-                        'invoiceId' => $invoice->getId(),
-                        'exception' => $e->getMessage(),
-                        'trace' => $e->getTraceAsString(),
-                    ],
-                );
-                $responseData = 'An error occurred while rendering the invoice. Please try again later.';
-                $header = ['Content-Type' => 'text/html'];
-
-                return new Response($responseData, 500, $header);
+                return new Response('An error occurred while rendering the invoice.', 500, ['Content-Type' => 'text/html']);
             }
 
             return new Response($responseData, 200, $header);
@@ -255,7 +243,6 @@ public static function getSubscribedServices(): array
                 new SubscribedService('coreshop.order.transformer.order_to_invoice', OrderDocumentTransformerInterface::class, attributes: new Autowire('@CoreShop\Component\Order\Transformer\OrderToInvoiceTransformer')),
                 new SubscribedService('coreshop.repository.order_invoice', OrderInvoiceRepositoryInterface::class, attributes: new Autowire(service:'coreshop.repository.order_invoice')),
                 new SubscribedService(StateMachineManagerInterface::class, StateMachineManagerInterface::class),
-                new SubscribedService(LoggerInterface::class, LoggerInterface::class),
             ]);
     }
 }

src/CoreShop/Bundle/OrderBundle/Controller/OrderShipmentController.php

@@ -36,7 +36,6 @@
 use CoreShop\Component\Order\Transformer\OrderToShipmentTransformer;
 use CoreShop\Component\Resource\Factory\FactoryInterface;
 use CoreShop\Component\Resource\Repository\PimcoreRepositoryInterface;
-use Psr\Log\LoggerInterface;
 use Symfony\Component\DependencyInjection\Attribute\Autowire;
 use Symfony\Component\EventDispatcher\GenericEvent;
 use Symfony\Component\HttpFoundation\JsonResponse;
@@ -184,18 +183,7 @@ public function renderAction(Request $request): Response
                     'Content-Disposition' => 'inline; filename="shipment-' . $shipment->getId() . '.pdf"',
                 ];
             } catch (\Exception $e) {
-                $this->container->get(LoggerInterface::class)->error(
-                    'Failed to render shipment PDF',
-                    [
-                        'shipmentId' => $shipment->getId(),
-                        'exception' => $e->getMessage(),
-                        'trace' => $e->getTraceAsString(),
-                    ],
-                );
-                $responseData = 'An error occurred while rendering the shipment. Please try again later.';
-                $header = ['Content-Type' => 'text/html'];
-
-                return new Response($responseData, 500, $header);
+                return new Response('An error occurred while rendering the shipment.', 500, ['Content-Type' => 'text/html']);
             }
 
             return new Response($responseData, 200, $header);
@@ -251,7 +239,6 @@ public static function getSubscribedServices(): array
                 new SubscribedService('event_dispatcher', EventDispatcherInterface::class),
                 new SubscribedService(OrderToShipmentTransformer::class, OrderToShipmentTransformer::class),
                 new SubscribedService(ErrorSerializer::class, ErrorSerializer::class),
-                new SubscribedService(LoggerInterface::class, LoggerInterface::class),
             ]);
     }
 }