Skip to content

Commit e003d15

Browse files
committed
fix(carousels): images and intervals cleanup
1 parent b1444f1 commit e003d15

File tree

2 files changed

+23
-17
lines changed

2 files changed

+23
-17
lines changed

src/app/views/base/carousels.component.html

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,15 @@
1111
</div>
1212
</div>
1313
<div class="card-body">
14-
<carousel [interval]="3000">
14+
<carousel [interval]="false">
1515
<slide>
16-
<img src="https://loremflickr.com/900/500/mountains?lock=1" alt="First slide" style="display: block; width: 100%;">
16+
<img src="https://lorempixel.com/900/500/nature/1" alt="First slide" style="display: block; width: 100%;">
1717
</slide>
1818
<slide>
19-
<img src="https://loremflickr.com/900/500/mountains?lock=2" alt="Second slide" style="display: block; width: 100%;">
19+
<img src="https://lorempixel.com/900/500/nature/2" alt="Second slide" style="display: block; width: 100%;">
2020
</slide>
2121
<slide>
22-
<img src="https://loremflickr.com/900/500/mountains?lock=3" alt="Third slide" style="display: block; width: 100%;">
22+
<img src="https://lorempixel.com/900/500/nature/3" alt="Third slide" style="display: block; width: 100%;">
2323
</slide>
2424
</carousel>
2525
</div>
@@ -32,23 +32,23 @@
3232
<small> optional captions</small>
3333
</div>
3434
<div class="card-body">
35-
<carousel [interval]="4500">
35+
<carousel [interval]="false">
3636
<slide>
37-
<img src="https://loremflickr.com/900/500/nature?lock=1" alt="First slide" style="display: block; width: 100%;">
37+
<img src="https://lorempixel.com/900/500/technics/1" alt="First slide" style="display: block; width: 100%;">
3838
<div class="carousel-caption d-none d-md-block">
3939
<h3>First slide label</h3>
4040
<p>Nulla vitae elit libero, a pharetra augue mollis interdum.</p>
4141
</div>
4242
</slide>
4343
<slide>
44-
<img src="https://loremflickr.com/900/500/nature?lock=2" alt="Second slide" style="display: block; width: 100%;">
44+
<img src="https://lorempixel.com/900/500/technics/2" alt="Second slide" style="display: block; width: 100%;">
4545
<div class="carousel-caption d-none d-md-block">
4646
<h3>Second slide label</h3>
4747
<p>Lorem ipsum dolor sit amet, consectetur adipiscing elit.</p>
4848
</div>
4949
</slide>
5050
<slide>
51-
<img src="https://loremflickr.com/900/500/nature?lock=3" alt="Third slide" style="display: block; width: 100%;">
51+
<img src="https://lorempixel.com/900/500/technics/3" alt="Third slide" style="display: block; width: 100%;">
5252
<div class="carousel-caption d-none d-md-block">
5353
<h3>Third slide label</h3>
5454
<p>Praesent commodo cursus magna, vel scelerisque nisl consectetur.</p>
@@ -67,23 +67,23 @@ <h3>Third slide label</h3>
6767
<small> configuring defaults</small>
6868
</div>
6969
<div class="card-body">
70-
<carousel>
70+
<carousel [interval]="false">
7171
<slide>
72-
<img src="https://loremflickr.com/900/500/city?lock=1" alt="First slide" style="display: block; width: 100%;">
72+
<img src="https://lorempixel.com/900/500/city/1" alt="First slide" style="display: block; width: 100%;">
7373
<div class="carousel-caption d-none d-md-block">
7474
<h3>First slide label</h3>
7575
<p>Nulla vitae elit libero, a pharetra augue mollis interdum.</p>
7676
</div>
7777
</slide>
7878
<slide>
79-
<img src="https://loremflickr.com/900/500/city?lock=2" alt="Second slide" style="display: block; width: 100%;">
79+
<img src="https://lorempixel.com/900/500/city/2" alt="Second slide" style="display: block; width: 100%;">
8080
<div class="carousel-caption d-none d-md-block">
8181
<h3>Second slide label</h3>
8282
<p>Lorem ipsum dolor sit amet, consectetur adipiscing elit.</p>
8383
</div>
8484
</slide>
8585
<slide>
86-
<img src="https://loremflickr.com/900/500/city?lock=3" alt="Third slide" style="display: block; width: 100%;">
86+
<img src="https://lorempixel.com/900/500/city/3" alt="Third slide" style="display: block; width: 100%;">
8787
<div class="carousel-caption d-none d-md-block">
8888
<h3>Third slide label</h3>
8989
<p>Praesent commodo cursus magna, vel scelerisque nisl consectetur.</p>

src/app/views/base/carousels.component.ts

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
1-
import { Component } from '@angular/core';
1+
import {Component, OnDestroy} from '@angular/core';
22
import { CarouselConfig } from 'ngx-bootstrap/carousel';
33

44
@Component({
55
templateUrl: 'carousels.component.html',
66
providers: [
7-
{ provide: CarouselConfig, useValue: { interval: 1500, noPause: true } },
7+
{ provide: CarouselConfig, useValue: { interval: 1500, noPause: false } },
88
]
99
})
10-
export class CarouselsComponent {
10+
export class CarouselsComponent implements OnDestroy {
1111

12-
myInterval: number = 6000;
12+
myInterval: number | false = 6000;
1313
slides: any[] = [];
1414
activeSlideIndex: number = 0;
1515
noWrapSlides: boolean = false;
@@ -20,9 +20,15 @@ export class CarouselsComponent {
2020
}
2121
}
2222

23+
ngOnDestroy(): void {
24+
this.myInterval = 0;
25+
this.noWrapSlides = true;
26+
this.myInterval = false;
27+
}
28+
2329
addSlide(): void {
2430
this.slides.push({
25-
image: `https://loremflickr.com/900/500/sailing?random=${this.slides.length % 8 + 1}/`
31+
image: `https://lorempixel.com/900/500/abstract/${this.slides.length % 8 + 1}/`
2632
});
2733
}
2834

0 commit comments

Comments
 (0)