Skip to content

Commit 04e1176

Browse files
committed
Improvements
1 parent 9172f58 commit 04e1176

File tree

2 files changed

+11
-28
lines changed
  • React_Full_Project/src/components/Header
  • React_Starter/src/components/Header

2 files changed

+11
-28
lines changed

React_Full_Project/src/components/Header/Header.js

Lines changed: 9 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -52,14 +52,10 @@ class Header extends Component {
5252
render() {
5353
return (
5454
<header className="app-header navbar">
55-
<NavbarToggler className="mobile-sidebar-toggler d-lg-none" onClick={this.mobileSidebarToggle}>&#9776;</NavbarToggler>
56-
{/* <button className="navbar-toggler mobile-sidebar-toggler d-lg-none" type="button" onClick={this.mobileSidebarToggle}>&#9776;</button>*/}
55+
<NavbarToggler className="d-lg-none" onClick={this.mobileSidebarToggle}>&#9776;</NavbarToggler>
5756
<NavbarBrand href="#"></NavbarBrand>
58-
<Nav className="navbar-nav d-md-down-none">
59-
<NavItem>
60-
<NavbarToggler className="nav-link sidebar-toggler" type="button"
61-
onClick={this.sidebarToggle}>&#9776;</NavbarToggler>
62-
</NavItem>
57+
<NavbarToggler className="d-md-down-none" onClick={this.sidebarToggle}>&#9776;</NavbarToggler>
58+
<Nav className="d-md-down-none" navbar>
6359
<NavItem className="px-3">
6460
<NavLink href="#">Dashboard</NavLink>
6561
</NavItem>
@@ -70,7 +66,7 @@ class Header extends Component {
7066
<NavLink href="#">Settings</NavLink>
7167
</NavItem>
7268
</Nav>
73-
<Nav className="navbar-nav ml-auto">
69+
<Nav className="ml-auto" navbar>
7470
<NavItem className="d-md-down-none">
7571
<NavLink href="#"><i className="icon-bell"></i><Badge pill color="danger">5</Badge></NavLink>
7672
</NavItem>
@@ -87,33 +83,24 @@ class Header extends Component {
8783
<span className="d-md-down-none">admin</span>
8884
</DropdownToggle>
8985
<DropdownMenu right className={this.state.dropdownOpen ? 'show' : ''}>
90-
<DropdownItem header className="text-center"><strong>Account</strong></DropdownItem>
91-
86+
<DropdownItem header tag="div" className="text-center"><strong>Account</strong></DropdownItem>
9287
<DropdownItem><i className="fa fa-bell-o"></i> Updates<Badge color="info">42</Badge></DropdownItem>
93-
<DropdownItem><i className="fa fa-envelope-o"></i> Messages<Badge
94-
color="success">42</Badge></DropdownItem>
88+
<DropdownItem><i className="fa fa-envelope-o"></i> Messages<Badge color="success">42</Badge></DropdownItem>
9589
<DropdownItem><i className="fa fa-tasks"></i> Tasks<Badge color="danger">42</Badge></DropdownItem>
96-
<DropdownItem><i className="fa fa-comments"></i> Comments<Badge
97-
color="warning">42</Badge></DropdownItem>
98-
99-
<DropdownItem header className="text-center"><strong>Settings</strong></DropdownItem>
100-
90+
<DropdownItem><i className="fa fa-comments"></i> Comments<Badge color="warning">42</Badge></DropdownItem>
91+
<DropdownItem header tag="div" className="text-center"><strong>Settings</strong></DropdownItem>
10192
<DropdownItem><i className="fa fa-user"></i> Profile</DropdownItem>
10293
<DropdownItem><i className="fa fa-wrench"></i> Settings</DropdownItem>
10394
<DropdownItem><i className="fa fa-usd"></i> Payments<Badge color="secondary">42</Badge></DropdownItem>
10495
<DropdownItem><i className="fa fa-file"></i> Projects<Badge color="primary">42</Badge></DropdownItem>
10596
<DropdownItem divider/>
10697
<DropdownItem><i className="fa fa-shield"></i> Lock Account</DropdownItem>
10798
<DropdownItem><i className="fa fa-lock"></i> Logout</DropdownItem>
108-
10999
</DropdownMenu>
110100
</Dropdown>
111101
</NavItem>
112-
<NavItem className="d-md-down-none">
113-
<NavbarToggler className="nav-link aside-menu-toggler" type="button"
114-
onClick={this.asideToggle}>&#9776;</NavbarToggler>
115-
</NavItem>
116102
</Nav>
103+
<NavbarToggler className="d-md-down-none" type="button" onClick={this.asideToggle}>&#9776;</NavbarToggler>
117104
</header>
118105
)
119106
}

React_Starter/src/components/Header/Header.js

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,13 +31,9 @@ class Header extends Component {
3131
render() {
3232
return (
3333
<header className="app-header navbar">
34-
<NavbarToggler className="mobile-sidebar-toggler d-lg-none" onClick={this.mobileSidebarToggle}>&#9776;</NavbarToggler>
34+
<NavbarToggler className="d-lg-none" onClick={this.mobileSidebarToggle}>&#9776;</NavbarToggler>
3535
<NavbarBrand href="#"></NavbarBrand>
36-
<Nav className="navbar-nav d-md-down-none mr-auto">
37-
<NavItem>
38-
<NavbarToggler className="nav-link sidebar-toggler" type="button" onClick={this.sidebarToggle}>&#9776;</NavbarToggler>
39-
</NavItem>
40-
</Nav>
36+
<NavbarToggler className="d-md-down-none mr-auto" onClick={this.sidebarToggle}>&#9776;</NavbarToggler>
4137
</header>
4238
)
4339
}

0 commit comments

Comments
 (0)