fix: Event listeners for Sidebar and AsideMenu plugins persist in jQuery instance

Author: xidedix

js/src/ajax-load.js

@@ -58,6 +58,7 @@ const AjaxLoad = (($) => {
       } else {
         this.setUpUrl(this._config.defaultPage)
       }
+      this._removeEventListeners()
       this._addEventListeners()
     }
 
@@ -167,6 +168,10 @@ const AjaxLoad = (($) => {
       })
     }
 
+    _removeEventListeners() {
+      $(document).off(Event.CLICK, `${Selector.NAV_LINK}[href!="#"]`)
+    }
+
     // Static
 
     static _jQueryInterface(config) {

js/src/aside-menu.js

@@ -51,6 +51,7 @@ const AsideMenu = (($) => {
   class AsideMenu {
     constructor(element) {
       this._element = element
+      this._removeEventListeners()
       this._addEventListeners()
     }
 
@@ -71,6 +72,10 @@ const AsideMenu = (($) => {
       })
     }
 
+    _removeEventListeners() {
+      $(document).off(Event.CLICK, Selector.ASIDE_MENU_TOGGLER)
+    }
+
     // Static
 
     static _jQueryInterface() {
@@ -92,7 +97,7 @@ const AsideMenu = (($) => {
    * ------------------------------------------------------------------------
    */
 
-  $(window).on(Event.LOAD_DATA_API, () => {
+  $(window).one(Event.LOAD_DATA_API, () => {
     const asideMenu = $(Selector.ASIDE_MENU)
     AsideMenu._jQueryInterface.call(asideMenu)
   })

js/src/sidebar.js

@@ -87,6 +87,7 @@ const Sidebar = (($) => {
       this.setActiveLink()
       this._breakpointTest = this._breakpointTest.bind(this)
       this._clickOutListener = this._clickOutListener.bind(this)
+      this._removeEventListeners()
       this._addEventListeners()
       this._addMediaQuery()
     }
@@ -260,6 +261,14 @@ const Sidebar = (($) => {
       })
     }
 
+    _removeEventListeners() {
+      $(document).off(Event.CLICK, Selector.BRAND_MINIMIZER)
+      $(document).off(Event.CLICK, Selector.NAV_DROPDOWN_TOGGLE)
+      $(document).off(Event.CLICK, Selector.SIDEBAR_MINIMIZER)
+      $(document).off(Event.CLICK, Selector.SIDEBAR_TOGGLER)
+      $(`${Selector.NAVIGATION} > ${Selector.NAV_ITEM} ${Selector.NAV_LINK}:not(${Selector.NAV_DROPDOWN_TOGGLE})`).off(Event.CLICK)
+    }
+
     // Static
 
     static _jQueryInterface() {
@@ -281,7 +290,7 @@ const Sidebar = (($) => {
    * ------------------------------------------------------------------------
    */
 
-  $(window).on(Event.LOAD_DATA_API, () => {
+  $(window).one(Event.LOAD_DATA_API, () => {
     const sidebar = $(Selector.SIDEBAR)
     Sidebar._jQueryInterface.call(sidebar)
   })