Skip to content

Commit 5967ebd

Browse files
rohit2sharma95mdo
authored andcommitted
Use the switch statement instead of if
1 parent f94f497 commit 5967ebd

File tree

1 file changed

+54
-63
lines changed

1 file changed

+54
-63
lines changed

build/build-plugins.js

Lines changed: 54 additions & 63 deletions
Original file line numberDiff line numberDiff line change
@@ -59,76 +59,67 @@ const defaultPluginConfig = {
5959
}
6060

6161
const getConfigByPluginKey = pluginKey => {
62-
if (
63-
pluginKey === 'Data' ||
64-
pluginKey === 'Manipulator' ||
65-
pluginKey === 'EventHandler' ||
66-
pluginKey === 'SelectorEngine' ||
67-
pluginKey === 'Util' ||
68-
pluginKey === 'Sanitizer' ||
69-
pluginKey === 'Backdrop'
70-
) {
71-
return {
72-
external: []
62+
switch (pluginKey) {
63+
case 'Alert':
64+
case 'Offcanvas':
65+
case 'Tab':
66+
return defaultPluginConfig
67+
68+
case 'Base':
69+
case 'Button':
70+
case 'Carousel':
71+
case 'Collapse':
72+
case 'Modal':
73+
case 'ScrollSpy': {
74+
const config = Object.assign(defaultPluginConfig)
75+
config.external.push(bsPlugins.Manipulator)
76+
config.globals[bsPlugins.Manipulator] = 'Manipulator'
77+
return config
7378
}
74-
}
75-
76-
if (pluginKey === 'Alert' || pluginKey === 'Tab' || pluginKey === 'Offcanvas') {
77-
return defaultPluginConfig
78-
}
7979

80-
if (
81-
pluginKey === 'Base' ||
82-
pluginKey === 'Button' ||
83-
pluginKey === 'Carousel' ||
84-
pluginKey === 'Collapse' ||
85-
pluginKey === 'Modal' ||
86-
pluginKey === 'ScrollSpy'
87-
) {
88-
const config = Object.assign(defaultPluginConfig)
89-
config.external.push(bsPlugins.Manipulator)
90-
config.globals[bsPlugins.Manipulator] = 'Manipulator'
91-
return config
92-
}
80+
case 'Dropdown':
81+
case 'Tooltip': {
82+
const config = Object.assign(defaultPluginConfig)
83+
config.external.push(bsPlugins.Manipulator, '@popperjs/core')
84+
config.globals[bsPlugins.Manipulator] = 'Manipulator'
85+
config.globals['@popperjs/core'] = 'Popper'
86+
return config
87+
}
9388

94-
if (pluginKey === 'Dropdown' || pluginKey === 'Tooltip') {
95-
const config = Object.assign(defaultPluginConfig)
96-
config.external.push(bsPlugins.Manipulator, '@popperjs/core')
97-
config.globals[bsPlugins.Manipulator] = 'Manipulator'
98-
config.globals['@popperjs/core'] = 'Popper'
99-
return config
100-
}
89+
case 'Popover':
90+
return {
91+
external: [
92+
bsPlugins.Data,
93+
bsPlugins.SelectorEngine,
94+
bsPlugins.Tooltip
95+
],
96+
globals: {
97+
[bsPlugins.Data]: 'Data',
98+
[bsPlugins.SelectorEngine]: 'SelectorEngine',
99+
[bsPlugins.Tooltip]: 'Tooltip'
100+
}
101+
}
101102

102-
if (pluginKey === 'Popover') {
103-
return {
104-
external: [
105-
bsPlugins.Data,
106-
bsPlugins.SelectorEngine,
107-
bsPlugins.Tooltip
108-
],
109-
globals: {
110-
[bsPlugins.Data]: 'Data',
111-
[bsPlugins.SelectorEngine]: 'SelectorEngine',
112-
[bsPlugins.Tooltip]: 'Tooltip'
103+
case 'Toast':
104+
return {
105+
external: [
106+
bsPlugins.Data,
107+
bsPlugins.Base,
108+
bsPlugins.EventHandler,
109+
bsPlugins.Manipulator
110+
],
111+
globals: {
112+
[bsPlugins.Data]: 'Data',
113+
[bsPlugins.Base]: 'Base',
114+
[bsPlugins.EventHandler]: 'EventHandler',
115+
[bsPlugins.Manipulator]: 'Manipulator'
116+
}
113117
}
114-
}
115-
}
116118

117-
if (pluginKey === 'Toast') {
118-
return {
119-
external: [
120-
bsPlugins.Data,
121-
bsPlugins.Base,
122-
bsPlugins.EventHandler,
123-
bsPlugins.Manipulator
124-
],
125-
globals: {
126-
[bsPlugins.Data]: 'Data',
127-
[bsPlugins.Base]: 'Base',
128-
[bsPlugins.EventHandler]: 'EventHandler',
129-
[bsPlugins.Manipulator]: 'Manipulator'
119+
default:
120+
return {
121+
external: []
130122
}
131-
}
132123
}
133124
}
134125

0 commit comments

Comments
 (0)