Skip to content

Commit 61050f7

Browse files
committed
fix: wrong select option background on Firefox when dark mode is on
1 parent 7ca4356 commit 61050f7

File tree

3 files changed

+15
-1
lines changed

3 files changed

+15
-1
lines changed

scss/_forms.scss

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,15 @@ select.form-control {
8989
}
9090
}
9191

92+
@-moz-document url-prefix() {
93+
select.form-control option {
94+
// Add background-color for elements in Firefox
95+
@include themes($form-theme-map, $create: parent) {
96+
background-color: themes-get-value("select-option-bg");
97+
}
98+
}
99+
}
100+
92101
// Make file inputs better match text inputs by forcing them to new lines.
93102
.form-control-file,
94103
.form-control-range {

scss/themes/dark/variables/components/_buttons-forms.scss

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ $input-plaintext-color__dt: $body-color__dt !default;
1515
$input-group-addon-color__dt: $body-color__dt !default;
1616
$input-group-addon-bg__dt: rgba($white, .09) !default;
1717
$input-group-addon-border-color__dt: rgba($white, .09) !default;
18+
$select-option-bg__dt: $bg-elevation-8 !default;
1819

1920
// stylelint-disable-next-line scss/dollar-variable-default
2021
$form-theme-map: map-merge(
@@ -33,6 +34,7 @@ $form-theme-map: map-merge(
3334
"input-group-addon-color": $input-group-addon-color__dt,
3435
"input-group-addon-bg": $input-group-addon-bg__dt,
3536
"input-group-addon-border-color": $input-group-addon-border-color__dt,
37+
"select-option-bg": $select-option-bg__dt
3638
)
3739
)
3840
);

scss/variables/components/_buttons-forms.scss

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,8 @@ $form-group-margin-bottom: 1rem !default;
140140
$input-group-addon-color: $input-color !default;
141141
$input-group-addon-bg: $gray-100 !default;
142142
$input-group-addon-border-color: $input-border-color !default;
143+
144+
$select-option-bg: inherit !default;
143145
// scss-docs-end forms
144146

145147
$form-theme-map: () !default;
@@ -158,7 +160,8 @@ $form-theme-map: map-merge(
158160
"input-plaintext-color": $input-plaintext-color,
159161
"input-group-addon-color": $input-group-addon-color,
160162
"input-group-addon-bg": $input-group-addon-bg,
161-
"input-group-addon-border-color": $input-group-addon-border-color
163+
"input-group-addon-border-color": $input-group-addon-border-color,
164+
"select-option-bg": $select-option-bg
162165
)
163166
),
164167
$form-theme-map

0 commit comments

Comments
 (0)