Skip to content

Commit c195d79

Browse files
committed
refactor(Header): remove default height
1 parent d97fd56 commit c195d79

File tree

1 file changed

+3
-12
lines changed

1 file changed

+3
-12
lines changed

scss/_header.scss

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
--#{$prefix}header-hover-color: #{$header-hover-color};
1111
--#{$prefix}header-disabled-color: #{$header-disabled-color};
1212
--#{$prefix}header-active-color: #{$header-active-color};
13+
--#{$prefix}header-transition: #{$header-transition};
1314
--#{$prefix}header-brand-padding-y: #{$header-brand-padding-y};
1415
--#{$prefix}header-brand-color: #{$header-brand-color};
1516
--#{$prefix}header-brand-hover-color: #{$header-brand-hover-color};
@@ -25,18 +26,18 @@
2526
--#{$prefix}header-nav-link-padding-y: #{$header-nav-link-padding-y};
2627
--#{$prefix}header-divider-border-color: #{$header-divider-border-color};
2728
--#{$prefix}header-divider-border: #{$header-divider-border-width} solid var(--#{$prefix}header-divider-border-color);
28-
--#{$prefix}subheader-min-height: #{$subheader-min-height};
2929
// scss-docs-end header-css-vars
3030

3131
position: relative;
3232
display: flex;
3333
flex-wrap: wrap; // allow us to do the line break for collapsing content
3434
align-items: center;
3535
justify-content: space-between; // space out brand from logo
36-
min-height: var(--#{$prefix}header-min-height);
36+
// min-height: var(--#{$prefix}header-min-height);
3737
padding: var(--#{$prefix}header-padding-y) var(--#{$prefix}header-padding-x);
3838
background: var(--#{$prefix}header-bg);
3939
border-bottom: var(--#{$prefix}header-border);
40+
@include transition(var(--#{$prefix}header-transition));
4041

4142
// Because flex properties aren't inherited, we need to redeclare these first
4243
// few properties so that content nested within behave properly.
@@ -59,16 +60,6 @@
5960
}
6061
}
6162

62-
.container:first-child,
63-
.container-fluid:first-child {
64-
min-height: calc(var(--#{$prefix}header-min-height) - (2 * var(--#{$prefix}header-padding-y))); // stylelint-disable-line function-disallowed-list
65-
}
66-
67-
.container:nth-child(n+2),
68-
.container-fluid:nth-child(n+2) {
69-
min-height: calc(var(--#{$prefix}subheader-min-height) - (2 * var(--#{$prefix}header-padding-y))); // stylelint-disable-line function-disallowed-list
70-
}
71-
7263
&.header-sticky {
7364
position: sticky;
7465
top: 0;

0 commit comments

Comments
 (0)