Update multi-select.js

ksbecker · web-flow · commit c286de761af0 · 2022-12-01T14:24:56.000-05:00
I believe the overflow properly of the multi-select should be set to 'auto', not 'scroll' when a height is specified. This is personal preference, but I believe it makes a better UX.
diff --git a/js/src/multi-select.js b/js/src/multi-select.js
@@ -479,7 +479,7 @@ class MultiSelect extends BaseComponent {
 
     if (this._config.optionsMaxHeight !== 'auto') {
       optionsDiv.style.maxHeight = `${this._config.optionsMaxHeight}px`
-      optionsDiv.style.overflow = 'scroll'
+      optionsDiv.style.overflow = 'auto'
     }
 
     dropdownDiv.append(optionsDiv)

Original file line number	Diff line number	Diff line change
`@@ -479,7 +479,7 @@ class MultiSelect extends BaseComponent {`
`479`	`479`
`480`	`480`	`if (this._config.optionsMaxHeight !== 'auto') {`
`481`	`481`	optionsDiv.style.maxHeight = `${this._config.optionsMaxHeight}px`
`482`		`- optionsDiv.style.overflow = 'scroll'`
	`482`	`+ optionsDiv.style.overflow = 'auto'`
`483`	`483`	`}`
`484`	`484`
`485`	`485`	`dropdownDiv.append(optionsDiv)`