Skip to content

Commit d54cd65

Browse files
committed
fix: wrong select background-position and validation icon position when RTL is enabled.
1 parent 0e73350 commit d54cd65

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

scss/forms/_form-select.scss

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,7 @@
66
.form-select {
77
display: block;
88
width: 100%;
9-
padding: $form-select-padding-y $form-select-indicator-padding $form-select-padding-y $form-select-padding-x;
10-
// stylelint-disable-next-line property-no-vendor-prefix
9+
@include ltr-rtl-value-only("padding", $form-select-padding-y $form-select-indicator-padding $form-select-padding-y $form-select-padding-x, $form-select-padding-y $form-select-padding-x $form-select-padding-y $form-select-indicator-padding);
1110
-moz-padding-start: subtract($form-select-padding-x, 3px); // See https://github.com/twbs/bootstrap/issues/32636
1211
font-family: $form-select-font-family;
1312
@include font-size($form-select-font-size);
@@ -17,7 +16,7 @@
1716
background-color: var(--#{$variable-prefix}form-select-bg, $form-select-bg);
1817
background-image: escape-svg($form-select-indicator);
1918
background-repeat: no-repeat;
20-
background-position: $form-select-bg-position;
19+
@include ltr-rtl-value-only("background-position", $form-select-bg-position);
2120
background-size: $form-select-bg-size;
2221
border: $form-select-border-width solid var(--#{$variable-prefix}form-select-border-color, $form-select-border-color);
2322
@include border-radius($form-select-border-radius, 0);

scss/mixins/_forms.scss

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@
6262
@include ltr-rtl("padding-right", $input-height-inner);
6363
background-image: escape-svg($icon);
6464
background-repeat: no-repeat;
65-
background-position: right $input-height-inner-quarter center;
65+
@include ltr-rtl-value-only("background-position", right $input-height-inner-quarter center, left $input-height-inner-quarter center);
6666
background-size: $input-height-inner-half $input-height-inner-half;
6767
}
6868

@@ -78,7 +78,8 @@
7878
@include form-validation-state-selector($state) {
7979
@if $enable-validation-icons {
8080
@include ltr-rtl("padding-right", $input-height-inner);
81-
background-position: top $input-height-inner-quarter right $input-height-inner-quarter;
81+
@include ltr-rtl-value-only("background-position", top $input-height-inner-quarter right $input-height-inner-quarter, top $input-height-inner-quarter left $input-height-inner-quarter);
82+
8283
}
8384
}
8485
}
@@ -92,7 +93,7 @@
9293
&:not([multiple])[size="1"] {
9394
@include ltr-rtl("padding-right", $form-select-feedback-icon-padding-end);
9495
background-image: escape-svg($form-select-indicator), escape-svg($icon);
95-
background-position: $form-select-bg-position, $form-select-feedback-icon-position;
96+
@include ltr-rtl-value-only("background-position", #{$form-select-bg-position, $form-select-feedback-icon-position});
9697
background-size: $form-select-bg-size, $form-select-feedback-icon-size;
9798
}
9899
}

0 commit comments

Comments
 (0)