Skip to content

Commit 17afaa5

Browse files
committed
refactor(COffcanvas): update backdrop class, update transition.
1 parent c1782bb commit 17afaa5

File tree

3 files changed

+22
-19
lines changed

3 files changed

+22
-19
lines changed

packages/coreui-vue/src/components/offcanvas/COffcanvas.ts

Lines changed: 19 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1-
import { defineComponent, h, ref, RendererElement, Transition, watch } from 'vue'
1+
import { defineComponent, h, ref, RendererElement, Transition, watch, withDirectives } from 'vue'
22
import { CBackdrop } from '../backdrop'
3+
import { vVisible } from '../../directives/v-c-visible'
34

45
const COffcanvas = defineComponent({
56
name: 'COffcanvas',
@@ -139,25 +140,27 @@ const COffcanvas = defineComponent({
139140
onAfterLeave: (el) => handleAfterLeave(el),
140141
},
141142
() =>
142-
visible.value &&
143-
h(
144-
'div',
145-
{
146-
class: [
147-
'offcanvas',
148-
{
149-
[`offcanvas-${props.placement}`]: props.placement,
150-
},
151-
],
152-
ref: offcanvasRef,
153-
role: 'dialog',
154-
},
155-
slots.default && slots.default(),
143+
withDirectives(
144+
h(
145+
'div',
146+
{
147+
class: [
148+
'offcanvas',
149+
{
150+
[`offcanvas-${props.placement}`]: props.placement,
151+
},
152+
],
153+
ref: offcanvasRef,
154+
role: 'dialog',
155+
},
156+
slots.default && slots.default(),
157+
),
158+
[[vVisible, props.visible]],
156159
),
157160
),
158161
props.backdrop &&
159162
h(CBackdrop, {
160-
class: 'modal-backdrop',
163+
class: 'offcanvas-backdrop',
161164
visible: visible.value,
162165
}),
163166
]

packages/coreui-vue/src/components/offcanvas/__tests__/COffcanvas.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,6 @@ describe(`Customize ${ComponentName} component`, () => {
4747
expect(customWrapper.text()).toContain('Default slot')
4848
expect(customWrapper.find('div').classes('offcanvas')).toBe(true)
4949
expect(customWrapper.find('div').classes('offcanvas-bottom')).toBe(true)
50-
expect(customWrapper.find('.modal-backdrop').classes('modal-backdrop')).toBe(true)
50+
expect(customWrapper.find('.offcanvas-backdrop').classes('offcanvas-backdrop')).toBe(true)
5151
})
5252
})

packages/coreui-vue/src/components/offcanvas/__tests__/__snapshots__/COffcanvas.spec.ts.snap

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ exports[`Customize COffcanvas component renders correctly 1`] = `
44
"<transition-stub>
55
<div class=\\"offcanvas offcanvas-bottom\\" role=\\"dialog\\">Default slot</div>
66
</transition-stub>
7-
<transition-stub class=\\"modal-backdrop\\">
7+
<transition-stub class=\\"offcanvas-backdrop\\">
88
<div class=\\"fade\\"></div>
99
</transition-stub>"
1010
`;
@@ -13,7 +13,7 @@ exports[`Loads and display COffcanvas component renders correctly 1`] = `
1313
"<transition-stub>
1414
<div class=\\"offcanvas offcanvas-end\\" role=\\"dialog\\">Default slot</div>
1515
</transition-stub>
16-
<transition-stub class=\\"modal-backdrop\\">
16+
<transition-stub class=\\"offcanvas-backdrop\\">
1717
<div class=\\"fade\\"></div>
1818
</transition-stub>"
1919
`;

0 commit comments

Comments
 (0)