upgrade linter and fix linter issues

Author: cornelk

.golangci.yml

@@ -1,54 +1,61 @@
 run:
-  deadline: 5m
+  timeout: 5m
 
 linters:
   enable:
     - asasalint # check for pass []any as any in variadic func(...any)
     - asciicheck # Simple linter to check that your code does not contain non-ASCII identifiers
     - bidichk # Checks for dangerous unicode character sequences
     - containedctx # detects struct contained context.Context field
-    - contextcheck # check the function whether to use a non-inherited context
+    - contextcheck # check the function whether use a non-inherited context
     - cyclop # checks function and package cyclomatic complexity
     - decorder # check declaration order and count of types, constants, variables and functions
     - dogsled # Checks assignments with too many blank identifiers (e.g. x, _, _, _, := f())
     - durationcheck # check for two durations multiplied together
+    - err113 # Golang linter to check the errors handling expressions
     - errcheck # checking for unchecked errors
     - errname # Checks that errors are prefixed with the `Err` and error types are suffixed with the `Error`
     - errorlint # finds code that will cause problems with the error wrapping scheme introduced in Go 1.13
-    - exportloopref # checks for pointers to enclosing loop variables
     - funlen # Tool for detection of long functions
     - gci # controls golang package import order and makes it always deterministic
+    - gocheckcompilerdirectives # Checks that go compiler directive comments (//go:) are valid
     - gocognit # Computes and checks the cognitive complexity of functions
     - gocritic # Provides diagnostics that check for bugs, performance and style issues
     - gocyclo # Computes and checks the cyclomatic complexity of functions
     - godot # Check if comments end in a period
-    - goerr113 # Golang linter to check the errors handling expressions
     - gofmt # checks whether code was gofmt-ed
+    - goimports # Check import statements are formatted according to the 'goimport' command
     - gosimple # Linter for Go source code that specializes in simplifying a code
     - govet # reports suspicious constructs, such as Printf calls with wrong arguments
+    - grouper # An analyzer to analyze expression groups
     - ineffassign # Detects when assignments to existing variables are not used
     - maintidx # measures the maintainability index of each function
     - makezero # Finds slice declarations with non-zero initial length
+    - mirror # reports wrong mirror patterns of bytes/strings usage
     - misspell # Finds commonly misspelled English words in comments
     - nakedret # Finds naked returns in functions
     - nestif # Reports deeply nested if statements
     - nilerr # Finds the code that returns nil even if it checks that the error is not nil
     - nilnil # Checks that there is no simultaneous return of `nil` error and an invalid value
-    - prealloc # Finds slice declarations that could potentially be pre-allocated
+    - perfsprint # Checks that fmt.Sprintf can be replaced with a faster alternative
+    - prealloc # Finds slice declarations that could potentially be preallocated
     - predeclared # find code that shadows one of Go's predeclared identifiers
+    - reassign # Checks that package variables are not reassigned
     - revive # drop-in replacement of golint
     - staticcheck # drop-in replacement of go vet
-    - stylecheck # replacement for golint
-    - tenv # detects using os.Setenv instead of t.Setenv
+    - stylecheck # Stylecheck is a replacement for golint
+    - testifylint # Checks usage of github.com/stretchr/testify
     - thelper # checks the consistency of test helpers
     - tparallel # detects inappropriate usage of t.Parallel()
     - typecheck # parses and type-checks Go code
     - unconvert # Remove unnecessary type conversions
     - unparam # Reports unused function parameters
     - unused # Checks Go code for unused constants, variables, functions and types
     - usestdlibvars # detect the possibility to use variables/constants from the Go standard library
+    - usetesting # Reports uses of functions with replacement inside the testing package
     - wastedassign # finds wasted assignment statements
     - whitespace # detects leading and trailing whitespace
+    - wrapcheck # Checks that errors returned from external packages are wrapped
 
 linters-settings:
   cyclop:
@@ -59,10 +66,12 @@ linters-settings:
   govet:
     disable:
       - unsafeptr
+  staticcheck:
+    # TODO SA1019 deprecated usage
+    checks: [ "all", "-SA1019" ]
 
 issues:
-  exclude-use-default: false
   exclude-rules:
     - linters:
-        - goerr113
+        - err113
       text: "do not define dynamic errors"

Makefile

@@ -1,4 +1,4 @@
-GOLANGCI_VERSION = v1.53.3
+GOLANGCI_VERSION = v1.64.6
 
 help: ## show help, shown by default if no target is specified
 	@grep -E '^[0-9a-zA-Z_-]+:.*?## .*$$' $(MAKEFILE_LIST) | sort | awk 'BEGIN {FS = ":.*?## "}; {printf "\033[36m%-30s\033[0m %s\n", $$1, $$2}'

assert/assert.go

@@ -33,7 +33,7 @@ func fail(t *testing.T, message string, errorMessage ...string) {
 	if len(errorMessage) != 0 {
 		message = fmt.Sprintf("%s\n%s", message, errorMessage)
 	}
-	t.Errorf(message)
+	t.Error(message)
 	t.FailNow()
 }
 

hashmap_test.go

@@ -1,6 +1,7 @@
 package hashmap
 
 import (
+	"errors"
 	"fmt"
 	"math"
 	"math/rand"
@@ -298,10 +299,10 @@ func TestRange(t *testing.T) {
 func TestHashMap_parallel(t *testing.T) {
 	m := New[int, int]()
 
-	max := 10
+	maxVal := 10
 	dur := 2 * time.Second
 
-	do := func(t *testing.T, max int, d time.Duration, fn func(*testing.T, int)) <-chan error {
+	do := func(t *testing.T, maxVal int, d time.Duration, fn func(*testing.T, int)) <-chan error {
 		t.Helper()
 		done := make(chan error)
 		var times int64
@@ -311,7 +312,7 @@ func TestHashMap_parallel(t *testing.T) {
 				select {
 				case <-time.After(d + 500*time.Millisecond):
 					if atomic.LoadInt64(&times) == 0 {
-						done <- fmt.Errorf("closure was not executed even once, something blocks it")
+						done <- errors.New("closure was not executed even once, something blocks it")
 					}
 					close(done)
 				case <-done:
@@ -323,7 +324,7 @@ func TestHashMap_parallel(t *testing.T) {
 			defer timer.Stop()
 		InfLoop:
 			for {
-				for i := 0; i < max; i++ {
+				for i := 0; i < maxVal; i++ {
 					select {
 					case <-timer.C:
 						break InfLoop
@@ -346,15 +347,15 @@ func TestHashMap_parallel(t *testing.T) {
 	}
 
 	// Initial fill.
-	for i := 0; i < max; i++ {
+	for i := 0; i < maxVal; i++ {
 		m.Set(i, i)
 	}
 	t.Run("set_get", func(t *testing.T) {
-		doneSet := do(t, max, dur, func(t *testing.T, i int) {
+		doneSet := do(t, maxVal, dur, func(t *testing.T, i int) {
 			t.Helper()
 			m.Set(i, i)
 		})
-		doneGet := do(t, max, dur, func(t *testing.T, i int) {
+		doneGet := do(t, maxVal, dur, func(t *testing.T, i int) {
 			t.Helper()
 			if _, ok := m.Get(i); !ok {
 				t.Errorf("missing value for key: %d", i)
@@ -364,11 +365,11 @@ func TestHashMap_parallel(t *testing.T) {
 		wait(t, doneGet)
 	})
 	t.Run("get-or-insert-and-delete", func(t *testing.T) {
-		doneGetOrInsert := do(t, max, dur, func(t *testing.T, i int) {
+		doneGetOrInsert := do(t, maxVal, dur, func(t *testing.T, i int) {
 			t.Helper()
 			m.GetOrInsert(i, i)
 		})
-		doneDel := do(t, max, dur, func(t *testing.T, i int) {
+		doneDel := do(t, maxVal, dur, func(t *testing.T, i int) {
 			t.Helper()
 			m.Del(i)
 		})

util_test.go

@@ -25,7 +25,7 @@ func TestLog2(t *testing.T) {
 func TestHashCollision(t *testing.T) {
 	m := New[string, int]()
 
-	staticHasher := func(key string) uintptr {
+	staticHasher := func(_ string) uintptr {
 		return 4 // chosen by fair dice roll. guaranteed to be random.
 	}