Skip to content

Commit 95badde

Browse files
committed
fix(metadata): Fix #4, caused by first render where no metadata exists yet while image is loading for WADO-URI
1 parent 05f58a4 commit 95badde

File tree

4 files changed

+22
-32
lines changed

4 files changed

+22
-32
lines changed

example/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
"moment": "^2.22.2",
1515
"prop-types": "^15.6.2",
1616
"react": "^16.4.1",
17-
"react-cornerstone-viewport": "^0.1.20",
17+
"react-cornerstone-viewport": "^0.1.21",
1818
"react-dom": "^16.4.1",
1919
"react-resize-detector": "^3.4.0",
2020
"react-scripts": "^2.1.5"

example/yarn.lock

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8015,10 +8015,10 @@ react-app-polyfill@^0.2.1:
80158015
raf "3.4.1"
80168016
whatwg-fetch "3.0.0"
80178017

8018-
react-cornerstone-viewport@^0.1.14:
8019-
version "0.1.14"
8020-
resolved "https://registry.yarnpkg.com/react-cornerstone-viewport/-/react-cornerstone-viewport-0.1.14.tgz#297d004c3e746c476fc785336a928096f257e860"
8021-
integrity sha512-PUnrDsQujOKEDuXVZFuxX3d8I4sEYtbNeTrGk5HPeFZXccIx+KSUf+qU06CsJnpMu4FqgaeHGtMVKm3hJJRmvg==
8018+
react-cornerstone-viewport@^0.1.21:
8019+
version "0.1.21"
8020+
resolved "https://registry.yarnpkg.com/react-cornerstone-viewport/-/react-cornerstone-viewport-0.1.21.tgz#6af0ab9a5c5384e5baf5d175ec846675d17bf177"
8021+
integrity sha512-lETYhekC2VawzVq9ZcZnavzgTE2mNeoB2Rh+H0HkMMyGBSl1ULxJvuZpm5KLPU00QujlbY8NKCe2rxKOhc0VZg==
80228022
dependencies:
80238023
lodash.debounce "^4.0.8"
80248024
moment "^2.23.0"

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "react-cornerstone-viewport",
3-
"version": "0.1.20",
3+
"version": "0.1.21",
44
"description": "Cornerstone medical image viewport component for React",
55
"author": "Cornerstone Contributors",
66
"license": "MIT",

src/ViewportOverlay/ViewportOverlay.js

Lines changed: 16 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,8 @@ const {
1515
} = helpers;
1616

1717
function getCompression(imageId) {
18-
const generalImageModule = cornerstone.metaData.get(
19-
'generalImageModule',
20-
imageId
21-
);
18+
const generalImageModule =
19+
cornerstone.metaData.get('generalImageModule', imageId) || {};
2220
const {
2321
lossyImageCompression,
2422
lossyImageCompressionRatio,
@@ -51,34 +49,26 @@ class ViewportOverlay extends PureComponent {
5149
}
5250

5351
const zoom = this.props.viewport.scale * 100;
54-
const seriesMetadata = cornerstone.metaData.get(
55-
'generalSeriesModule',
56-
imageId
57-
);
58-
const imagePlaneModule = cornerstone.metaData.get(
59-
'imagePlaneModule',
60-
imageId
61-
);
62-
const { rows, columns, sliceThickness, sliceLocation } =
63-
imagePlaneModule || {};
64-
const { seriesNumber, seriesDescription } = seriesMetadata || {};
65-
66-
const generalStudyModule = cornerstone.metaData.get(
67-
'generalStudyModule',
68-
imageId
69-
);
52+
const seriesMetadata =
53+
cornerstone.metaData.get('generalSeriesModule', imageId) || {};
54+
const imagePlaneModule =
55+
cornerstone.metaData.get('imagePlaneModule', imageId) || {};
56+
const { rows, columns, sliceThickness, sliceLocation } = imagePlaneModule;
57+
const { seriesNumber, seriesDescription } = seriesMetadata;
58+
59+
const generalStudyModule =
60+
cornerstone.metaData.get('generalStudyModule', imageId) || {};
7061
const { studyDate, studyTime, studyDescription } = generalStudyModule;
7162

72-
const patientModule = cornerstone.metaData.get('patientModule', imageId);
63+
const patientModule =
64+
cornerstone.metaData.get('patientModule', imageId) || {};
7365
const { patientId, patientName } = patientModule;
7466

75-
const generalImageModule = cornerstone.metaData.get(
76-
'generalImageModule',
77-
imageId
78-
);
67+
const generalImageModule =
68+
cornerstone.metaData.get('generalImageModule', imageId) || {};
7969
const { instanceNumber } = generalImageModule;
8070

81-
const cineModule = cornerstone.metaData.get('cineModule', imageId);
71+
const cineModule = cornerstone.metaData.get('cineModule', imageId) || {};
8272
const { frameTime } = cineModule;
8373

8474
const frameRate = formatNumberPrecision(1000 / frameTime, 1);

0 commit comments

Comments
 (0)