Skip to content

Commit cd4dfe7

Browse files
authored
Revert "Viewport (#10)" (#14)
This reverts commit 23d41fc.
1 parent 23d41fc commit cd4dfe7

File tree

2 files changed

+4
-116
lines changed

2 files changed

+4
-116
lines changed

example/src/App.js

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,6 @@ export default class App extends Component {
1616
}
1717
}
1818

19-
const viewport = {
20-
invert: true,
21-
voi: {}
22-
};
23-
2419
const style = {
2520
'height': '512px'
2621
};
@@ -39,9 +34,8 @@ export default class App extends Component {
3934
<div className='col-xs-12 col-lg-6' style={style}>
4035
<CornerstoneViewport
4136
viewportData={exampleData}
42-
cornerstone={cornerstone}
37+
cornerstone={cornerstone}
4338
cornerstoneTools={cornerstoneTools}
44-
viewport={viewport}
4539
/>
4640
</div>
4741
</div>

src/CornerstoneViewport/CornerstoneViewport.js

Lines changed: 3 additions & 109 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,6 @@ class CornerstoneViewport extends Component {
5959
isPlaying: false,
6060
cineFrameRate: 24
6161
},
62-
viewport: null,
6362
availableTools: [
6463
{ name: 'Pan', mouseButtonMasks: [1, 4] },
6564
{
@@ -95,7 +94,6 @@ class CornerstoneViewport extends Component {
9594
onMeasurementsChanged: PropTypes.func,
9695
onElementEnabled: PropTypes.func,
9796
isActive: PropTypes.bool.isRequired,
98-
viewport: PropTypes.object,
9997
layout: PropTypes.object,
10098
children: PropTypes.node,
10199
onDoubleClick: PropTypes.func,
@@ -129,8 +127,7 @@ class CornerstoneViewport extends Component {
129127
isLoading: false,
130128
numImagesLoaded: 0,
131129
error: null,
132-
viewport:
133-
props.viewport || cornerstone.getDefaultViewport(null, undefined)
130+
viewport: cornerstone.getDefaultViewport(null, undefined)
134131
};
135132

136133
const { loadHandlerManager } = cornerstoneTools;
@@ -424,16 +421,8 @@ class CornerstoneViewport extends Component {
424421
return;
425422
}
426423

427-
const defaultViewport = cornerstone.getDefaultViewportForImage(
428-
element,
429-
image
430-
);
431-
432-
const viewport = Object.assign(
433-
{},
434-
defaultViewport,
435-
this.state.viewport
436-
);
424+
// Set Soft Tissue preset for all images by default
425+
const viewport = cornerstone.getDefaultViewportForImage(element, image);
437426

438427
// Display the first image
439428
cornerstone.displayImage(element, image, viewport);
@@ -724,101 +713,6 @@ class CornerstoneViewport extends Component {
724713
);
725714
}
726715
}
727-
728-
// TODO? Should we shallow equality check these?
729-
if (this.props.viewport !== prevProps.viewport) {
730-
// Update the internal representation of the viewport parameters
731-
let viewport = Object.assign(
732-
{},
733-
this.state.viewport,
734-
this.props.viewport
735-
);
736-
737-
// Handle reset and fitToWindow cases
738-
// If viewport.scale === null or voi === null, call getDefaultViewportForImage
739-
// and use these values prior to calling setViewport
740-
741-
const defaultViewport = cornerstone.getDefaultViewportForImage(
742-
this.element,
743-
cornerstone.getImage(this.element)
744-
);
745-
if (viewport.voi === null) {
746-
viewport.voi = defaultViewport.voi;
747-
}
748-
749-
if (viewport.zoomScale !== null) {
750-
const maximumScale = 10;
751-
const minimumScale = 0.05;
752-
753-
if (viewport.zoomScale === 0) {
754-
viewport.scale = defaultViewport.scale;
755-
} else if (viewport.zoomScale < 0) {
756-
viewport.scale = Math.max(
757-
viewport.scale + viewport.zoomScale,
758-
minimumScale
759-
);
760-
} else {
761-
viewport.scale = Math.min(
762-
viewport.scale + viewport.zoomScale,
763-
maximumScale
764-
);
765-
}
766-
}
767-
768-
if (viewport.resetViewport) {
769-
viewport = defaultViewport;
770-
}
771-
772-
if (viewport.clearTools) {
773-
const toolStateManager =
774-
cornerstoneTools.globalImageIdSpecificToolStateManager;
775-
toolStateManager.clear(this.element);
776-
cornerstone.updateImage(this.element);
777-
}
778-
779-
if (viewport.scrollUp) {
780-
let stack = this.state.stack;
781-
stack.currentImageIdIndex = Math.min(
782-
this.state.numImagesLoaded,
783-
++stack.currentImageIdIndex
784-
);
785-
786-
scrollToIndex(this.element, stack.currentImageIdIndex);
787-
this.setState({ stack });
788-
}
789-
790-
if (viewport.scrollDown) {
791-
let stack = this.state.stack;
792-
stack.currentImageIdIndex = Math.max(0, --stack.currentImageIdIndex);
793-
scrollToIndex(this.element, stack.currentImageIdIndex);
794-
this.setState({ stack });
795-
}
796-
797-
if (viewport.scrollFirstImage) {
798-
let stack = this.state.stack;
799-
stack.currentImageIdIndex = 0;
800-
scrollToIndex(this.element, stack.currentImageIdIndex);
801-
this.setState({ stack });
802-
}
803-
804-
if (viewport.scrollLastImage) {
805-
let stack = this.state.stack;
806-
const numImagesLoaded = this.state.stack.imageIds.length - 1;
807-
scrollToIndex(this.element, numImagesLoaded);
808-
this.setState({ stack });
809-
}
810-
811-
if (viewport.nextPanel) {
812-
const enabledElements = cornerstone.getEnabledElements();
813-
this.element = enabledElements;
814-
}
815-
816-
this.setState({
817-
viewport
818-
});
819-
820-
cornerstone.setViewport(this.element, viewport);
821-
}
822716
}
823717

824718
setActiveTool = activeTool => {

0 commit comments

Comments
 (0)