-
Notifications
You must be signed in to change notification settings - Fork 28
Description
Good day Sirs!
I am again demonstrating coroot to my customers explaining them that it is a good solution. To do it I prepared FluxCD manifests. Everything fine for the exception that Coroot CE does not look like a thing that could be installed in one go. Let's say as a DevOps I want to publish coroot outside to be accessible by users. I need to set up ingress to do it. And what do I see? Completely different semantics than I'm used to see before.
I see the next default values:
ingress:
enabled: false
className: ""
hostname:
path: /
pathType: ImplementationSpecific
annotations: {}
# kubernetes.io/ingress.class: nginx
# kubernetes.io/tls-acme: "true"
hosts: []
# - host: chart-example.local
# paths:
# - path: /
# pathType: ImplementationSpecific
tls: []
# - secretName: chart-example-tls
# hosts:
# - chart-example.local
so I am just filling hostname and hosts (no idea why, because charts of other application use this semantics) and.... nothing.
I think it would be great to change templates and values to the next as project is on early stage of development and in future it would be much harder to do it:
ingress: # GOOD!
enabled: false # GOOD!
# className: "" # change to ingressClassName
ingressClassName: ""
# hostname: # throwing away
# path: / # throwing away
# pathType: ImplementationSpecific # throwing away
annotations: {} # GOOD!
# kubernetes.io/ingress.class: nginx
# kubernetes.io/tls-acme: "true"
hosts: [] # GOOD!
# - host: chart-example.local
# paths:
# - path: /
# pathType: ImplementationSpecific
tls: [] # GOOD!
# - secretName: chart-example-tls
# hosts:
# - chart-example.local
so main changes are
- remove
classNamein favour ofingressClassName. The logic behind it that there is noclassNamefield in Ingress spec and many charts useingressClassName(examples: sentry, nixys universal chart, victoria stack). It is clear and standard. I don't think that it is good to be different - remove dedicated
hostname/path/pathTypekeys. If user of the chart wants, it would be easy to him to populatehostslists like it is done in other charts. Now the two settings creates confusion. I may guess that authors of the coroot chart thought that user may want to add additional hosts to the default one. But in fact managing of single list is simpler.