Add status to headers for all responses

Author: Casao

Gemfile.lock

@@ -0,0 +1,48 @@
+PATH
+  remote: .
+  specs:
+    cortex-client (0.2.5)
+      faraday (~> 0.9)
+      faraday_middleware (~> 0.9.0)
+      oauth2 (~> 0.9)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    diff-lcs (1.2.5)
+    faraday (0.9.0)
+      multipart-post (>= 1.2, < 3)
+    faraday_middleware (0.9.1)
+      faraday (>= 0.7.4, < 0.10)
+    jwt (1.0.0)
+    multi_json (1.10.1)
+    multi_xml (0.5.5)
+    multipart-post (2.0.0)
+    oauth2 (0.9.4)
+      faraday (>= 0.8, < 0.10)
+      jwt (~> 1.0)
+      multi_json (~> 1.3)
+      multi_xml (~> 0.5)
+      rack (~> 1.2)
+    rack (1.5.2)
+    rake (10.3.2)
+    rspec (3.0.0)
+      rspec-core (~> 3.0.0)
+      rspec-expectations (~> 3.0.0)
+      rspec-mocks (~> 3.0.0)
+    rspec-core (3.0.3)
+      rspec-support (~> 3.0.0)
+    rspec-expectations (3.0.3)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.0.0)
+    rspec-mocks (3.0.3)
+      rspec-support (~> 3.0.0)
+    rspec-support (3.0.3)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  cortex-client!
+  rake (~> 10.3.2)
+  rspec (~> 3.0)

lib/cortex/request.rb

@@ -50,9 +50,9 @@ def save(path, model)
 
     def parse_response(response)
       if response.status < 300 || (response.body.kind_of?(Hash) && response.body['error'])
-        OpenStruct.new({body: response.body, headers: response.headers.select { |k| ['content-range', 'x-total-items'].include? k } })
+        OpenStruct.new({body: response.body, headers: { status: response.status }.merge(response.headers.select { |k| ['content-range', 'x-total-items'].include? k })  })
       else
-        OpenStruct.new({:error => response.body, :status => response.status, :original => response})
+        OpenStruct.new({body: {error: response.body, status: response.status, original: response}, headers: { status: response.status }})
       end
     end
   end

lib/cortex/version.rb

@@ -1,3 +1,3 @@
 module Cortex
-  VERSION = '0.2.5'
+  VERSION = '0.2.6'
 end

spec/request_spec.rb

@@ -6,27 +6,28 @@
   context 'with a cortex error response' do
     it 'should return the error object' do
       body = {'error' => 'Validation error or something'}
-      response = OpenStruct.new(:status => 422, :body => body, :headers => { :whatever => "Whatever"})
-      expect(client.parse_response(response).to_h).to eq({ :body => body, :headers => {}})
+      response = OpenStruct.new(status: 422, body: body, headers: { :whatever => "Whatever"})
+      expect(client.parse_response(response).to_h).to eq({ :body => body, :headers => {status: 422}})
     end
   end
 
   context 'with a non-cortex error response' do
     it 'should return a wrapped response' do
       body = 'Catastrophic error'
-      response = OpenStruct.new(:status => 500, :body => body, :headers => { :whatever => "Whatever" })
+      response = OpenStruct.new(status: 500, body: body, headers: { whatever: "Whatever", status: 500 } )
       parsed = client.parse_response(response)
-      expect(parsed.error).to eq(body)
-      expect(parsed.status).to eq(500)
-      expect(parsed.original).to eq(response)
+      expect(parsed.body[:error]).to eq(body)
+      expect(parsed.body[:status]).to eq(500)
+      expect(parsed.body[:original]).to eq(response)
+      expect(parsed.headers[:status]).to eq(500)
     end
   end
 
   context 'with a successful response' do
     it 'should return the parsed body' do
       body = {:id => 1, title: 'A post'}
-      response = OpenStruct.new(:status => 200, :body => body, :headers => { :whatever => "Whatever" })
-      expect(client.parse_response(response).to_h).to eq({ :body => body, :headers => {}})
+      response = OpenStruct.new(status: 200, body: body, headers: { :whatever => "Whatever" })
+      expect(client.parse_response(response).to_h).to eq({ body: body, headers: {status: 200}})
     end
   end
 end