Procs for validations

Author: MKwenhua

app/models/float_field_type.rb

@@ -2,8 +2,8 @@ class FloatFieldType < FieldType
   attr_accessor :float
 
   validates_numericality_of :float
-  validate :less_than, if: :validate_min?
-  validate :greater_than, if: :validate_max?
+  validate :less_than, if: Proc.new { |int| validate_key(:max) }
+  validate :greater_than, if: Proc.new { |int| validate_key(:min) }
 
   def data=(data_hash)
     @float = data_hash.deep_symbolize_keys[:float]
@@ -25,24 +25,15 @@ def mapping_field_name
     "#{field_name.parameterize('_')}_float"
   end
 
+  def validate_key(key)
+    @validations.key? key
+  end
+
   def less_than
      errors.add(:float, "must be less_than #{@validations[:max]}") if :float <= @validations[:max]
   end
 
   def greater_than
      errors.add(:float, "must be greater_than #{@validations[:min]}") if :float >= @validations[:min]
   end
-
-  def validate_max?
-    @validations.key? :max
-  end
-
-  def validate_min?
-    @validations.key? :min
-  end
-  
-  def valid_presence_validation?
-    @validations.key? :presence
-  end
- 
 end

app/models/integer_field_type.rb

@@ -1,10 +1,9 @@
 class IntegerFieldType < FieldType
   attr_accessor :integer
 
-  validates :integer, presence: true, if: :validate_presence?
   validates_numericality_of :integer
-  validate :less_than, if: :validate_min?
-  validate :greater_than, if: :validate_max?
+  validate :less_than, if: Proc.new { |int| validate_key(:max) }
+  validate :greater_than, if:  Proc.new { |int| validate_key(:min) }
 
   def data=(data_hash)
     @integer = data_hash.deep_symbolize_keys[:integer]
@@ -26,24 +25,15 @@ def mapping_field_name
     "#{field_name.parameterize('_')}_integer"
   end
 
-  def less_than
-     errors.add(:integer, "must be less_than #{@validations[:max]}") if :integer <= validations[:max]
-  end
-
-  def greater_than
-     errors.add(:integer, "must be greater_than #{@validations[:min]}") if :integer >= validations[:min]
+  def validate_key
+    @validations.key? key
   end
 
-  def validate_max?
-    @validations.key? :max
+  def less_than
+     errors.add(:integer, "must be less_than #{@validations[:max]}") if :integer <= @validations[:max]
   end
 
-  def validate_min?
-    @validations.key? :min
-  end
-  
-  def valid_presence_validation?
-    @validations.key? :presence
+  def greater_than
+     errors.add(:integer, "must be greater_than #{@validations[:min]}") if :integer >= @validations[:min]
   end
- 
 end