Added some missing stuff in Attachable Clear and Save that should have been there

Cleaned up some whitespace and method comments in attachable

Author: garethyr

Entities/Attachable.cpp

@@ -35,13 +35,16 @@ namespace RTE {
 
 		m_InheritsHFlipped = 1;
 		m_InheritsRotAngle = true;
-		m_InheritedRotAngleOffset = 0.0F;
+		m_InheritedRotAngleOffset = 0;
 		m_InheritsFrame = false;
 
 		m_AtomSubgroupID = -1L;
 		m_CollidesWithTerrainWhileAttached = true;
 
-		m_PrevRotAngleOffset = 0.0F;
+		m_PrevParentOffset.Reset();
+		m_PrevJointOffset.Reset();
+		m_PrevRotAngleOffset = 0;
+		m_PreUpdateHasRunThisFrame = false;
 	}
 
 /////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
@@ -142,36 +145,23 @@ namespace RTE {
 	int Attachable::Save(Writer &writer) const {
 		MOSRotating::Save(writer);
 
-		writer.NewProperty("ParentOffset");
-		writer << m_ParentOffset;
-		writer.NewProperty("DrawAfterParent");
-		writer << m_DrawAfterParent;
-		writer.NewProperty("DeleteWhenRemovedFromParent");
-		writer << m_DeleteWhenRemovedFromParent;
-		writer.NewProperty("ApplyTransferredForcesAtOffset");
-		writer << m_ApplyTransferredForcesAtOffset;
-
-		writer.NewProperty("JointStrength");
-		writer << m_JointStrength;
-		writer.NewProperty("JointStiffness");
-		writer << m_JointStiffness;
-		writer.NewProperty("JointOffset");
-		writer << m_JointOffset;
-
-		writer.NewProperty("BreakWound");
-		writer << m_BreakWound;
-		writer.NewProperty("ParentBreakWound");
-		writer << m_ParentBreakWound;
-
-		writer.NewProperty("InheritsHFlipped");
-		writer << ((m_InheritsHFlipped == 0 || m_InheritsHFlipped == 1) ? m_InheritsHFlipped : 2);
-		writer.NewProperty("InheritsRotAngle");
-		writer << m_InheritsRotAngle;
-		writer.NewProperty("InheritedRotAngleOffset");
-		writer << m_InheritedRotAngleOffset;
-
-		writer.NewProperty("CollidesWithTerrainWhileAttached");
-		writer << m_CollidesWithTerrainWhileAttached;
+		writer.NewPropertyWithValue("ParentOffset", m_ParentOffset);
+		writer.NewPropertyWithValue("DrawAfterParent", m_DrawAfterParent);
+		writer.NewPropertyWithValue("DeleteWhenRemovedFromParent", m_DeleteWhenRemovedFromParent);
+		writer.NewPropertyWithValue("ApplyTransferredForcesAtOffset", m_ApplyTransferredForcesAtOffset);
+
+		writer.NewPropertyWithValue("JointStrength", m_JointStrength);
+		writer.NewPropertyWithValue("JointStiffness", m_JointStiffness);
+		writer.NewPropertyWithValue("JointOffset", m_JointOffset);
+
+		writer.NewPropertyWithValue("BreakWound", m_BreakWound);
+		writer.NewPropertyWithValue("ParentBreakWound", m_ParentBreakWound);
+
+		writer.NewPropertyWithValue("InheritsHFlipped", ((m_InheritsHFlipped == 0 || m_InheritsHFlipped == 1) ? m_InheritsHFlipped : 2));
+		writer.NewPropertyWithValue("InheritsRotAngle", m_InheritsRotAngle);
+		writer.NewPropertyWithValue("InheritedRotAngleOffset", m_InheritedRotAngleOffset);
+
+		writer.NewPropertyWithValue("CollidesWithTerrainWhileAttached", m_CollidesWithTerrainWhileAttached);
 
 		return 0;
 	}
@@ -452,7 +442,7 @@ namespace RTE {
 		//TODO Get rid of the need for calling ResetAllTimers, if something like inventory swapping needs timers reset it should do it itself! This blanket handling probably has side-effects.
 		// Timers are reset here as a precaution, so that if something was sitting in an inventory, it doesn't cause backed up emissions.
 		ResetAllTimers();
-		
+
 		if (newParent) {
 			m_Parent = newParent;
 			m_Team = newParent->GetTeam();

Entities/Attachable.h

@@ -25,7 +25,7 @@ namespace RTE {
 		/// Constructor method used to instantiate a Attachable object in system memory. Create() should be called before using the object.
 		/// </summary>
 		Attachable() { Clear(); }
-		
+
 		/// <summary>
 		/// Makes the Attachable object ready for use.
 		/// </summary>
@@ -304,14 +304,14 @@ namespace RTE {
 #pragma region Inherited Value Getters and Setters
 		/// <summary>
 		/// Gets whether or not this Attachable inherits its parent's HFlipped value, i.e. whether it has its HFlipped value reset to match/reverse its parent's every frame, if attached.
-		/// -1 (or technically any value that's not 0 or 1) means reversed inheritance (i.e. if the parent's HFlipped value is true, this Attachable's HFlipped value will be false), 0 means no inheritance, 1 means normal inheritance.
+		/// 0 means no inheritance, 1 means normal inheritance, anything else means reversed inheritance (i.e. if the parent's HFlipped value is true, this Attachable's HFlipped value will be false).
 		/// </summary>
 		/// <returns>Whether or not this Attachable inherits its parent's HFlipped value.</returns>
 		int InheritsHFlipped() const { return m_InheritsHFlipped; }
 
 		/// <summary>
 		/// Sets whether or not this Attachable inherits its parent's HFlipped value, i.e. whether it has its HFlipped value reset to match/reverse its parent's every frame, if attached.
-		/// -1 (or technically any value that's not 0 or 1) means reversed inheritance (i.e. if the parent's HFlipped value is true, this Attachable's HFlipped value will be false), 0 means no inheritance, 1 means normal inheritance.
+		/// 0 means no inheritance, 1 means normal inheritance, anything else means reversed inheritance (i.e. if the parent's HFlipped value is true, this Attachable's HFlipped value will be false).
 		/// </summary>
 		/// <param name="inheritsRotAngle">Whether or not to inherit its parent's HFlipped value.</param>
 		void SetInheritsHFlipped(int inheritsHFlipped) { m_InheritsHFlipped = inheritsHFlipped; }
@@ -524,10 +524,10 @@ namespace RTE {
 		bool m_DrawnNormallyByParent; //!< Whether this Attachable will be drawn normally when attached, or will require special handling by some non-MOSR parent type.
 		bool m_DeleteWhenRemovedFromParent; //!< Whether this Attachable should be deleted when it's removed from its parent.
 		bool m_ApplyTransferredForcesAtOffset; //!< Whether forces transferred from this Attachable should be applied at the rotated parent offset (which will produce torque), or directly at the parent's position. Mostly useful to make jetpacks and similar emitters viable.
-		
+
 		float m_GibWithParentChance; //!< The percentage chance that this Attachable will gib when its parent does. 0 means never, 1 means always.
 		float m_ParentGibBlastStrengthMultiplier; //!< The multiplier for how strongly this Attachable's parent's gib blast strength will be applied to it when its parent's gibs.
-		
+
 		//TODO This is a stopgap for a dedicated Wound class, that would be helpful to simplify things like this and default damage multiplier handling.
 		bool m_IsWound; //!< Whether or not this Attachable has been added as a wound. Only set and applied for Attachables with parents.