Remove incorrect variable declaration in RTEError

Some minor formatting

Author: MaximDude

System/RTEError.cpp

@@ -12,11 +12,12 @@ namespace RTE {
 	extern bool RTEAbortFunc(const char *description, const char *file, int line) {
 		// Save out the screen bitmap, after making a copy of it, faster sometimes
 		if (screen) {
-			if (!g_ScreendumpBuffer) { g_ScreendumpBuffer = create_bitmap(screen->w, screen->h); }
-			blit(screen, g_ScreendumpBuffer, 0, 0, 0, 0, screen->w, screen->h);
+			BITMAP *abortScreenBuffer = create_bitmap(screen->w, screen->h);
+			blit(screen, abortScreenBuffer, 0, 0, 0, 0, screen->w, screen->h);
 			PALETTE palette;
 			get_palette(palette);
-			save_bmp("abortscreen.bmp", g_ScreendumpBuffer, palette);
+			save_bmp("abortscreen.bmp", abortScreenBuffer, palette);
+			destroy_bitmap(abortScreenBuffer);
 		}
 		// Ditch the video mode so the message box appears without problems
 		if (screen != 0) { set_gfx_mode(GFX_TEXT, 0, 0, 0, 0); }

System/RTEError.h

@@ -12,8 +12,6 @@
 
 namespace RTE {
 
-	static BITMAP *g_ScreendumpBuffer = 0; //!< Buffer for saving abort screendumps.
-
 	/// <summary>
 	/// Pops up a message box dialog in the OS. For debug purposes mostly.
 	/// </summary>
@@ -28,12 +26,11 @@ namespace RTE {
 	/// <param name="line">The line where the abortion is made.</param>
 	extern bool RTEAbortFunc(const char *description, const char *file, int line);
 	extern bool RTEAbortFunc(const std::string description, const char *file, int line);
-	#define RTEAbort(description) \
-	{ \
-		if (RTEAbortFunc(description, __FILE__, __LINE__)) { \
-			DebuggerBreak \
-		} \
+
+	#define RTEAbort(description) {												\
+		if (RTEAbortFunc(description, __FILE__, __LINE__)) { DebuggerBreak }	\
 	}
+
 	/// <summary>
 	/// A souped-up, customized assert function that brings up a nice dialog box on assert failure.
 	/// The user can choose to break or ignore the particular assertion failure once, or to always ignore.
@@ -46,14 +43,12 @@ namespace RTE {
 	/// <returns>Whether the assertion failed AND the user chose to break in the dialog box.</returns>
 	extern bool RTEAssertFunc(bool expression, const char *description, const char *file, int line, bool &alwaysIgnore);
 	extern bool RTEAssertFunc(bool expression, const std::string description, const char *file, int line, bool &alwaysIgnore);
-	#define RTEAssert(expression, description) \
-	{ \
-		static bool alwaysIgnore= false; \
-		if (!alwaysIgnore) { \
-			if (RTEAssertFunc(expression, description, __FILE__, __LINE__, alwaysIgnore)) { \
-				DebuggerBreak \
-			} \
-		} \
+
+	#define RTEAssert(expression, description) {															\
+		static bool alwaysIgnore = false;																	\
+		if (!alwaysIgnore) {																				\
+			if (RTEAssertFunc(expression, description, __FILE__, __LINE__, alwaysIgnore)) { DebuggerBreak }	\
+		}																									\
 	}
 }
 #endif