Modified AudioMan PlaySound to so it doesn't call SetPitch and SetAttenuation, in order to lower the number of SoundEvents registered and sent back and forth during multiplayer.

Changed size limit of NetworkSoundData SoundFileHashes to c_MaxPlayingSoundsPerContainer to lower the struct's size. I was confused when I set it to c_MaxAudioChannels anyway; if a SoundContainer can only have 64 channels playing at once, it couldn't need more than that many hashes.
Made the number of sound events required to trigger early sending of sound events to clients be based on the size of the NetworkSoundData struct, so it won't overflow its limits

Author: garethyr

Managers/AudioMan.cpp

@@ -427,8 +427,9 @@ namespace RTE {
 			return false;
 		}
 
+		attenuation = Limit(attenuation, 0.95, 0); //Limit attenuation so it can't be closer than 0 (full volume) or farther than 0.95 (quiet but not quite silent)
 		priority = priority < 0 ? pSoundContainer->GetPriority() : priority;
-		pitch = pSoundContainer->IsAffectedByGlobalPitch() ? m_GlobalPitch : pitch;
+		pitch = Limit(pSoundContainer->IsAffectedByGlobalPitch() ? m_GlobalPitch : pitch, 8, 0.125); //Limit pitch change to 8 octaves up or down, and set it to global pitch if applicable
 
 		FMOD::Channel *channel;
 		FMOD_RESULT result = FMOD_OK;
@@ -442,24 +443,24 @@ namespace RTE {
 			result = result == FMOD_OK ? channel->getIndex(&channelIndex) : result;
 			result = result == FMOD_OK ? channel->setUserData(pSoundContainer) : result;
 			result = result == FMOD_OK ? channel->setCallback(SoundChannelEndedCallback) : result;
+			result = result == FMOD_OK ? channel->setVolume(1 - attenuation) : result;
 			result = result == FMOD_OK ? channel->setLoopCount(pSoundContainer->GetLoopSetting()) : result;
 			result = result == FMOD_OK ? channel->setPriority(priority) : result;
+			result = result == FMOD_OK ? channel->setPitch(pitch) : result;
 		}
 
 		if (result != FMOD_OK) {
 			g_ConsoleMan.PrintString("ERROR: Could not play sounds from SoundContainer " + pSoundContainer->GetPresetName() + ": " + std::string(FMOD_ErrorString(result)));
 			return false;
 		}
 
-		pSoundContainer->AddPlayingChannel(channelIndex);
-		SetSoundAttenuation(pSoundContainer, attenuation);
-		if (pitch != 1) { SetSoundPitch(pSoundContainer, pitch); }
-
 		result = channel->setPaused(false);
 		if (result != FMOD_OK) {
 			g_ConsoleMan.PrintString("ERROR: Failed to start playing sounds from SoundContainer " + pSoundContainer->GetPresetName() + " after setting it up: " + std::string(FMOD_ErrorString(result)));
 		}
 
+		pSoundContainer->AddPlayingChannel(channelIndex);
+
 		// Now that the sound is playing we can register an event with the SoundContainer's channels, which can be used by clients to identify the sound being played.
 		if (m_IsInMultiplayerMode) {
 			RegisterSoundEvent(player, SOUND_PLAY, pSoundContainer->GetPlayingChannels(), &pSoundContainer->GetSelectedSoundHashes(), attenuation, pSoundContainer->GetLoopSetting(), pitch, pSoundContainer->IsAffectedByGlobalPitch());
@@ -604,7 +605,7 @@ namespace RTE {
 				if (channels) {
 					std::copy(channels->begin(), channels->end(), soundData.Channels);
 				}
-				std::fill_n(soundData.SoundFileHashes, c_MaxAudioChannels, 0);
+				std::fill_n(soundData.SoundFileHashes, c_MaxPlayingSoundsPerContainer, 0);
 				if (soundFileHashes) {
 					std::copy(soundFileHashes->begin(), soundFileHashes->end(), soundData.SoundFileHashes);
 				}

Managers/AudioMan.h

@@ -57,7 +57,7 @@ namespace RTE {
 		struct NetworkSoundData {
 			unsigned char State;
 			unsigned short int Channels[c_MaxPlayingSoundsPerContainer];
-			size_t SoundFileHashes[c_MaxAudioChannels];
+			size_t SoundFileHashes[c_MaxPlayingSoundsPerContainer];
 			short int Distance;
 			short int Loops;
 			float Pitch;

Managers/NetworkClient.cpp

@@ -715,7 +715,7 @@ namespace RTE
 						}
 
 						// We always have to add the newly made sound container to the map of server sounds, regardless of whether we were able to delete existing sounds above
-						if (sndDataPtr->State == AudioMan::SOUND_PLAY) { m_ServerSounds[serverSoundChannelIndex] = newlyMadeSoundContainer; }
+						if (sndDataPtr->State == AudioMan::SOUND_PLAY) { m_ServerSounds.insert({serverSoundChannelIndex, soundContainerToHandle}); }
 					}
 				}
 			}

Managers/NetworkServer.cpp

@@ -1237,7 +1237,8 @@ namespace RTE
 			msg->SoundEventsCount++;
 			sndDataPtr++;
 
-			if (msg->SoundEventsCount >= 50)
+			//If one more sound would overflow the container, send sounds now then reset to continue
+			if ((msg->SoundEventsCount * sizeof(AudioMan::NetworkSoundData)) >= (MAX_PIXEL_LINE_BUFFER_SIZE - sizeof(AudioMan::NetworkSoundData) - sizeof(MsgSoundEvents)))
 			{
 				//char buf[128];
 				//sprintf_s(buf, sizeof(buf), "%d %d", msg->FrameNumber, msg->PostEffectsCount);