Fix not being able to place brains anywhere under a blocked ceiling in bunker editing phase

Author: fourZK

Menus/SceneEditorGUI.cpp

@@ -311,7 +311,7 @@ bool SceneEditorGUI::TestBrainResidence(bool noBrainIsOK)
     {
         // Got to update the pathfinding graphs so the latest terrain is used for the below tests
         g_SceneMan.GetScene()->UpdatePathFinding();
-        m_BrainSkyPathCost = g_SceneMan.GetScene()->CalculatePath(pBrain->GetPos(), Vector(pBrain->GetPos().m_X, 0), m_BrainSkyPath);
+		UpdateBrainSkyPathAndCost(pBrain->GetPos());
     }
     else
     {
@@ -709,7 +709,7 @@ void SceneEditorGUI::Update()
         m_CursorInAir = g_SceneMan.GetTerrMatter(snappedPos.GetFloorIntX(), snappedPos.GetFloorIntY()) == g_MaterialAir;
 
         // Check brain position validity with pathfinding and show a path to the sky
-        m_BrainSkyPathCost = g_SceneMan.GetScene()->CalculatePath(m_CursorPos, Vector(m_CursorPos.m_X, 0), m_BrainSkyPath);
+		UpdateBrainSkyPathAndCost(m_CursorPos);
 /*
         // Process the new path we now have, if any
         if (!m_BrainSkyPath.empty())
@@ -784,8 +784,7 @@ void SceneEditorGUI::Update()
             g_FrameMan.SetScreenText("Release to ADD the new object - Tap other button to cancel", g_ActivityMan.GetActivity()->ScreenOfPlayer(m_pController->GetPlayer()));
 
         // Check brain position validity with pathfinding and show a path to the sky
-        if (m_PreviousMode == INSTALLINGBRAIN)
-            m_BrainSkyPathCost = g_SceneMan.GetScene()->CalculatePath(m_CursorPos, Vector(m_CursorPos.m_X, 0), m_BrainSkyPath);
+		if (m_PreviousMode == INSTALLINGBRAIN) { UpdateBrainSkyPathAndCost(m_CursorPos); }
 
         m_DrawCurrentObject = true;
 
@@ -1653,31 +1652,36 @@ void SceneEditorGUI::UpdatePieMenu()
     m_pPieMenu->RealignSlices();
 }
 
+/////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
+
+void SceneEditorGUI::UpdateBrainSkyPathAndCost(Vector brainPos) {
+	int offsetX = 0;
+	int spacing = 20;
+	int orbitPosX;
+	// If the ceiling directly above is blocked, search the surroundings for gaps.
+	for (int i = 0; i < g_SceneMan.GetSceneWidth() / spacing; i++) {
+		orbitPosX = brainPos.GetFloorIntX() + offsetX;
+		if (g_SceneMan.GetTerrMatter(orbitPosX, 0) == g_MaterialAir) {
+			break;
+		} else {
+			offsetX = i * (i % 2 == 0 ? spacing : -spacing);
+		}
+		if (!g_SceneMan.IsWithinBounds(orbitPosX, 0)) { offsetX *= -1; }
+	}
+	m_BrainSkyPathCost = g_SceneMan.GetScene()->CalculatePath(brainPos, Vector(orbitPosX, 0), m_BrainSkyPath, 5.0F);
+}
 
-//////////////////////////////////////////////////////////////////////////////////////////
-// Method:          UpdateBrainPath
-//////////////////////////////////////////////////////////////////////////////////////////
-// Description:     Updates the brain path to the current resident brain, if any. If
-//                  there's none, the path is cleared.
-
-bool SceneEditorGUI::UpdateBrainPath()
-{
-    // First see if we have a brain in hand
-    if (m_pCurrentObject && m_pCurrentObject->IsInGroup("Brains"))
-    {
-        m_BrainSkyPathCost = g_SceneMan.GetScene()->CalculatePath(m_CursorPos, Vector(m_CursorPos.m_X, 0), m_BrainSkyPath);
-        return true;
-    }
-
-    // If not, then do we have a resident?
-    SceneObject *pBrain = g_SceneMan.GetScene()->GetResidentBrain(m_pController->GetPlayer());
-    if (pBrain)
-        m_BrainSkyPathCost = g_SceneMan.GetScene()->CalculatePath(pBrain->GetPos(), Vector(pBrain->GetPos().m_X, 0), m_BrainSkyPath);
-    else
-    {
-        m_BrainSkyPath.clear();
-        m_BrainSkyPathCost = 0;
-        return false;
-    }
-    return true;
+/////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
+
+bool SceneEditorGUI::UpdateBrainPath() {
+	if (m_pCurrentObject && m_pCurrentObject->IsInGroup("Brains")) {
+		UpdateBrainSkyPathAndCost(m_CursorPos);
+	} else if (SceneObject *residentBrain = g_SceneMan.GetScene()->GetResidentBrain(m_pController->GetPlayer())) {
+		UpdateBrainSkyPathAndCost(residentBrain->GetPos());
+	} else {
+		m_BrainSkyPath.clear();
+		m_BrainSkyPathCost = 0;
+		return false;
+	}
+	return true;
 }

Menus/SceneEditorGUI.h

@@ -308,16 +308,17 @@ class SceneEditorGUI {
 
     void UpdatePieMenu();
 
-
-//////////////////////////////////////////////////////////////////////////////////////////
-// Method:          UpdateBrainPath
-//////////////////////////////////////////////////////////////////////////////////////////
-// Description:     Updates the brain path to the current brain in cursor or resident
-//                  in the scene, if any. If there's none, the path is cleared.
-// Arguments:       None.
-// Return value:    Whether a resident brain was found in the scene.
-
-    bool UpdateBrainPath();
+	/// <summary>
+	/// Updates the path to the current brain in the cursor or resident in the scene, if any. If there's none, the path is cleared.
+	/// </summary>
+	/// <returns>Whether a brain was found in the cursor or the scene.</returns>
+	bool UpdateBrainPath();
+
+	/// <summary>
+	/// Updates the path from the designated position to orbit, and its cost.
+	/// </summary>
+	/// <param name="brainPos">The designated position of the brain.</param>
+	void UpdateBrainSkyPathAndCost(Vector brainPos);
 
 
     enum BlinkMode