FIXME: std::format for some reason refuses to work in macos CI.

Author: HeliumAnt

Source/Managers/FrameMan.cpp

@@ -452,7 +452,7 @@ int FrameMan::SaveBitmap(SaveBitmapMode modeToSave, const std::string& nameBase,
 	}
 
 	// TODO: Remove this once GCC13 is released and switched to. std::format and std::chrono::time_zone are not part of latest libstdc++.
-#if defined(__GNUC__) && __GNUC__ < 13
+#if defined(__GNUC__) && (__GNUC__ < 13 || defined(__APPLE__)) //FIXME: macOS for some reason builds with incorrect iconv in CI which breaks format, could not debug.
 	std::chrono::time_point now = std::chrono::system_clock::now();
 	time_t currentTime = std::chrono::system_clock::to_time_t(now);
 	tm* localCurrentTime = std::localtime(&currentTime);

Source/Menus/SettingsVideoGUI.cpp

@@ -25,7 +25,7 @@
 using namespace RTE;
 
 std::string SettingsVideoGUI::PresetResolutionRecord::GetDisplayString() const {
-#if __cpp_lib_format >= 201907L
+#if __cpp_lib_format >= 201907L && !(defined(__APPLE__) && defined(__GNUC__)) //FIXME: macOS CI borken without this.
 	return std::format("{}x{} ({:.1g}x Fullscreen scale)", Width, Height, Scale);
 #else
 	return std::to_string(Width) + "x" + std::to_string(Height);
@@ -113,7 +113,7 @@ void SettingsVideoGUI::CreateCustomResolutionBox() {
 
 	m_CustomResolutionMultiplierComboBox = dynamic_cast<GUIComboBox*>(m_GUIControlManager->GetControl("ComboboxResolutionMultiplier"));
 	PopulateResMultplierComboBox();
-#if __cpp_lib_format >= 201907L
+#if __cpp_lib_format >= 201907L && !(defined(__APPLE__) && defined(__GNUC__))
 	m_CustomResolutionMultiplierComboBox->SetText(std::format("{:.3g}x", m_NewResMultiplier));
 #else
 	m_CustomResolutionMultiplierComboBox->SetText(std::to_string(m_NewResMultiplier));
@@ -131,7 +131,7 @@ void SettingsVideoGUI::SetEnabled(bool enable) const {
 	if (enable) {
 		m_CustomResolutionWidthTextBox->SetText(std::to_string(static_cast<int>(g_WindowMan.GetResX())));
 		m_CustomResolutionHeightTextBox->SetText(std::to_string(static_cast<int>(g_WindowMan.GetResY())));
-#if __cpp_lib_format >= 201907L
+#if __cpp_lib_format >= 201907L && !(defined(__APPLE__) && defined(__GNUC__))
 		m_CustomResolutionMultiplierComboBox->SetText(std::format("{:.3g}x", m_NewResMultiplier));
 #else
 		m_CustomResolutionMultiplierComboBox->SetText(std::to_string(m_NewResMultiplier));
@@ -200,7 +200,7 @@ void SettingsVideoGUI::PopulateResMultplierComboBox() {
 	m_CustomResolutionMultiplierComboBox->ClearList();
 
 	for (float resMultiplier = 1.0f; resMultiplier <= maximumResMultiplier; resMultiplier += 0.5) {
-#if __cpp_lib_format >= 201907L
+#if __cpp_lib_format >= 201907L && !(defined(__APPLE__) && defined(__GNUC__))
 		m_CustomResolutionMultiplierComboBox->AddItem(std::format("{:.3g}x", resMultiplier));
 #else
 		m_CustomResolutionMultiplierComboBox->AddItem(std::to_string(resMultiplier));