update GLCheck to be more informative and enable in release

Also disable GLCheck unconditionally aborting, now it just prints the error
to console.

Author: HeliumAnt

Source/System/GLCheck.cpp

@@ -1,13 +1,74 @@
 #include "GLCheck.h"
 #include "glad/gl.h"
 
-#include <cstdio>
-#include <cstdlib>
+#include <string>
+#include <sstream>
+#include "ConsoleMan.h"
 
 void CheckOpenGLError(const char* stmt, const char* fname, int line) {
-	GLenum err = glGetError();
-	if (err != GL_NO_ERROR) {
-		printf("OpenGL error %08x, at %s:%i - for %s\n", err, fname, line, stmt);
-		abort();
+	GLenum errorCode = glGetError();
+
+	if (errorCode != GL_NO_ERROR) {
+		std::string fileString = fname;
+		std::string error = "Unknown error";
+		std::string description = "No description";
+
+		// Decode the error code
+		switch (errorCode) {
+			case GL_INVALID_ENUM: {
+				error = "GL_INVALID_ENUM";
+				description = "An unacceptable value has been specified for an enumerated argument.";
+				break;
+			}
+
+			case GL_INVALID_VALUE: {
+				error = "GL_INVALID_VALUE";
+				description = "A numeric argument is out of range.";
+				break;
+			}
+
+			case GL_INVALID_OPERATION: {
+				error = "GL_INVALID_OPERATION";
+				description = "The specified operation is not allowed in the current state.";
+				break;
+			}
+
+			case GL_STACK_OVERFLOW: {
+				error = "GL_STACK_OVERFLOW";
+				description = "This command would cause a stack overflow.";
+				break;
+			}
+
+			case GL_STACK_UNDERFLOW: {
+				error = "GL_STACK_UNDERFLOW";
+				description = "This command would cause a stack underflow.";
+				break;
+			}
+
+			case GL_OUT_OF_MEMORY: {
+				error = "GL_OUT_OF_MEMORY";
+				description = "There is not enough memory left to execute the command.";
+				break;
+			}
+
+			case GL_INVALID_FRAMEBUFFER_OPERATION: {
+				error = "GL_INVALID_FRAMEBUFFER_OPERATION";
+				description = "The object bound to FRAMEBUFFER_BINDING is not \"framebuffer complete\".";
+				break;
+			}
+
+			default: {
+				error = "Unknown Error: " + std::to_string(errorCode);
+				description = "";
+			}
+		}
+
+		// Log the error
+		std::stringstream errorMessage;
+		errorMessage << "ERROR: An internal OpenGL call failed in "
+				  << fileString.substr(fileString.find_last_of("\\/") + 1) << "(" << line << ")."
+				  << "\nExpression:\n   " << stmt
+				  << "\nError description:\n   " << error << "\n   " << description << "\n";
+		g_ConsoleMan.PrintString(errorMessage.str());
 	}
-}
+}

Source/System/GLCheck.h

@@ -5,12 +5,8 @@
 void CheckOpenGLError(const char* stmt, const char* fname, int line);
 
 /// Debug macro to be used for all GL calls.
-#ifdef DEBUG
 #define GL_CHECK(stmt) \
 	do { \
 		stmt; \
 		CheckOpenGLError(#stmt, __FILE__, __LINE__); \
 	} while (0)
-#else
-#define GL_CHECK(stmt) stmt
-#endif