Revert "Fix mouse position, aim and pie menu pointing being reset at some inappropriate times, specifically when anyone with a controller opens or closes their pie menu."

This reverts commit c2a2c8f.

Author: Bit-Crust

Source/Activities/GameActivity.cpp

@@ -1055,7 +1055,7 @@ void GameActivity::UpdateEditing() {
 			DisableAIs(false);
 			InitAIs();
 			// Reset the mouse value and pathfinding so it'll know about the newly placed stuff
-			g_UInputMan.SetMouseValueMagnitude(0, g_UInputMan.MouseUsedByPlayer());
+			g_UInputMan.SetMouseValueMagnitude(0);
 			g_SceneMan.GetScene()->ResetPathFinding();
 			// Start the in-game track
 			// g_AudioMan.ClearMusicQueue();
@@ -1235,7 +1235,7 @@ void GameActivity::Update() {
 			if (m_PlayerController[player].IsState(PRESS_SECONDARY)) {
 				// Reset the mouse so the actor doesn't change aim because mouse has been moved
 				if (m_PlayerController[player].IsMouseControlled()) {
-					g_UInputMan.SetMouseValueMagnitude(0, player);
+					g_UInputMan.SetMouseValueMagnitude(0);
 				}
 
 				m_ViewState[player] = ViewState::Normal;
@@ -1254,7 +1254,7 @@ void GameActivity::Update() {
 			else if (m_PlayerController[player].IsState(ACTOR_NEXT) || m_PlayerController[player].IsState(ACTOR_PREV) || m_PlayerController[player].IsState(PRESS_FACEBUTTON) || m_PlayerController[player].IsState(PRESS_PRIMARY)) {
 				// Reset the mouse so the actor doesn't change aim because mouse has been moved
 				if (m_PlayerController[player].IsMouseControlled()) {
-					g_UInputMan.SetMouseValueMagnitude(0, player);
+					g_UInputMan.SetMouseValueMagnitude(0);
 				}
 
 				if (pMarkedActor) {

Source/Managers/ActivityMan.cpp

@@ -314,7 +314,7 @@ int ActivityMan::StartActivity(Activity* activity) {
 	g_FrameMan.ClearScreenText();
 
 	// Reset the mouse input to the center
-	g_UInputMan.SetMouseValueMagnitude(0, g_UInputMan.MouseUsedByPlayer());
+	g_UInputMan.SetMouseValueMagnitude(0.05F);
 
 	g_AudioMan.PauseIngameSounds(false);
 

Source/Managers/UInputMan.cpp

@@ -324,17 +324,15 @@ Vector UInputMan::GetMouseMovement(int whichPlayer) const {
 void UInputMan::SetMouseValueMagnitude(float magCap, int whichPlayer) {
 	if (IsInMultiplayerMode() && whichPlayer >= Players::PlayerOne && whichPlayer < Players::MaxPlayerCount) {
 		m_NetworkAnalogMoveData[whichPlayer].CapMagnitude(m_MouseTrapRadius * magCap);
-	} else if (whichPlayer != Players::NoPlayer && m_ControlScheme.at(whichPlayer).GetDevice() == InputDevice::DEVICE_MOUSE_KEYB) {
-		m_AnalogMouseData.SetMagnitude(m_MouseTrapRadius * magCap);
 	}
+	m_AnalogMouseData.SetMagnitude(m_MouseTrapRadius * magCap);
 }
 
 void UInputMan::SetMouseValueAngle(float angle, int whichPlayer) {
 	if (IsInMultiplayerMode() && whichPlayer >= Players::PlayerOne && whichPlayer < Players::MaxPlayerCount) {
 		m_NetworkAnalogMoveData[whichPlayer].SetAbsRadAngle(angle);
-	} else if (whichPlayer != Players::NoPlayer && m_ControlScheme.at(whichPlayer).GetDevice() == InputDevice::DEVICE_MOUSE_KEYB) {
-		m_AnalogMouseData.SetAbsRadAngle(angle);
 	}
+	m_AnalogMouseData.SetAbsRadAngle(angle);
 }
 
 void UInputMan::SetMousePos(const Vector& newPos, int whichPlayer) const {

Source/System/Controller.cpp

@@ -419,7 +419,7 @@ void Controller::UpdatePlayerAnalogInput() {
 	// Disable sharp aim while moving - this also helps with keyboard vs mouse fighting when moving and aiming in opposite directions
 	if (m_ControlStates[ControlState::BODY_JUMP] && !pieMenuActive) {
 		if (IsMouseControlled()) {
-			g_UInputMan.SetMouseValueMagnitude(0.3F, m_Player);
+			g_UInputMan.SetMouseValueMagnitude(0.3F);
 		}
 		m_ControlStates[ControlState::AIM_SHARP] = false;
 	}