Don't store module ID ContentFile was loaded from - get it from path on demand

Demand is literally in one place when texturizing terrain
Fixes my stack overflow lel AAAAAAAAAAAAAAAAAAAAAAAAA

Author: MaximDude

Entities/SLTerrain.cpp

@@ -141,7 +141,7 @@ namespace RTE {
 		BITMAP *defaultBGLayerTexture = m_DefaultBGTextureFile.GetAsBitmap();
 
 		const std::array<Material *, c_PaletteEntriesNumber> &materialPalette = g_SceneMan.GetMaterialPalette();
-		const std::array<unsigned char, c_PaletteEntriesNumber> &materialMappings = g_ModuleMan.GetDataModule(m_BitmapFile.GetDataModuleID())->GetAllMaterialMappings();
+		const std::array<unsigned char, c_PaletteEntriesNumber> &materialMappings = g_ModuleMan.GetDataModule(g_ModuleMan.GetModuleIDFromPath(m_BitmapFile.GetDataPath()))->GetAllMaterialMappings();
 
 		std::array<BITMAP *, c_PaletteEntriesNumber> materialFGTextures;
 		materialFGTextures.fill(nullptr);

System/ContentFile.cpp

@@ -26,7 +26,6 @@ namespace RTE {
 		m_DataPathIsImageFile = false;
 		m_FormattedReaderPosition.clear();
 		m_DataPathAndReaderPosition.clear();
-		m_DataModuleID = 0;
 
 		m_ImageFileInfo.fill(-1);
 	}
@@ -45,7 +44,6 @@ namespace RTE {
 		m_DataPath = reference.m_DataPath;
 		m_DataPathExtension = reference.m_DataPathExtension;
 		m_DataPathWithoutExtension = reference.m_DataPathWithoutExtension;
-		m_DataModuleID = reference.m_DataModuleID;
 
 		return 0;
 	}
@@ -81,12 +79,6 @@ namespace RTE {
 		return 0;
 	}
 
-/////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
-
-	int ContentFile::GetDataModuleID() const {
-		return (m_DataModuleID < 0) ? g_ModuleMan.GetModuleIDFromPath(m_DataPath) : m_DataModuleID;
-	}
-
 /////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
 
 	void ContentFile::SetDataPath(const std::string &newDataPath) {
@@ -99,7 +91,6 @@ namespace RTE {
 
 		m_DataPathWithoutExtension = m_DataPath.substr(0, m_DataPath.length() - m_DataPathExtension.length());
 		s_PathHashes[GetHash()] = m_DataPath;
-		m_DataModuleID = g_ModuleMan.GetModuleIDFromPath(m_DataPath);
 	}
 
 /////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////

System/ContentFile.h

@@ -69,12 +69,6 @@ namespace RTE {
 #pragma endregion
 
 #pragma region Getters and Setters
-		/// <summary>
-		/// Gets the ID of the Data Module this file is inside.
-		/// </summary>
-		/// <returns>The ID of the DataModule containing this' file.</returns>
-		int GetDataModuleID() const;
-
 		/// <summary>
 		/// Gets the file path of the content file represented by this ContentFile object.
 		/// </summary>
@@ -211,8 +205,6 @@ namespace RTE {
 		std::string m_FormattedReaderPosition; //!< A string containing the currently read file path and the line being read. Formatted to be used for logging.
 		std::string m_DataPathAndReaderPosition; //!< The path to this ContentFile's data file combined with the ini file and line it is being read from. This is used for logging.
 
-		int m_DataModuleID; //!< Data Module ID of where this was loaded from.
-
 #pragma region Image Info Getters
 		/// <summary>
 		/// Gets the specified image info from this ContentFile's data file on disk.