Improves grapple gun magazine reset and sounds

- Centralizes magazine state restoration logic in `RopeInputController` to ensure the gun's magazine correctly resets when the grapple is destroyed. This includes an attempt to re-establish the gun reference if initially lost.
- Adds sound playback when the grapple is unhooked by firing the gun, enhancing audio feedback.
- Strengthens validation of the parent gun reference within `RopeInputController` to more robustly handle scenarios where the gun might be invalid or inaccessible, preventing potential errors.

Author: OpenTools-run

Data/Base.rte/Devices/Tools/GrappleGun/Grapple.lua

@@ -788,6 +788,10 @@ function Update (self)
                 Logger.info("Grapple Update() - Gun fired while grapple active")
                 if self.actionMode == 1 then -- If flying, just delete
                     Logger.info("Grapple Update() - Flying mode: marking for deletion")
+                    if self.returnSound then 
+                        self.returnSound:Play(parentActor.Pos)
+                        Logger.debug("Grapple Update() - Return sound played for gun fire unhook (flying)")
+                    end
                     self.ToDelete = true
                 elseif self.actionMode > 1 then -- If attached, mark as ready to release
                     Logger.info("Grapple Update() - Attached mode: marking ready to release")
@@ -798,6 +802,10 @@ function Update (self)
             if self.canRelease and self.parentGun.FiredFrame and 
                (self.parentGun.Vel.Y ~= -1 or self.parentGun:IsActivated()) then
                 Logger.info("Grapple Update() - Release condition met, marking for deletion")
+                if self.returnSound then 
+                    self.returnSound:Play(parentActor.Pos)
+                    Logger.debug("Grapple Update() - Return sound played for gun fire unhook (attached)")
+                end
                 self.ToDelete = true
             end
         end
@@ -928,18 +936,21 @@ function Destroy(self)
         Logger.debug("Grapple Destroy() - Crank sound instance marked for deletion")
     end
 
+    -- Try to restore magazine state via the input controller first
+    RopeInputController.restoreMagazineState(self)
+    
     -- Clean up references on the parent gun
     if self.parentGun and self.parentGun.ID ~= rte.NoMOID then
         Logger.debug("Grapple Destroy() - Cleaning up parent gun references")
         self.parentGun.HUDVisible = true
         self.parentGun:RemoveNumberValue("GrappleMode")
         self.parentGun.StanceOffset = Vector(0,0)
 
-        -- Restore and show magazine when grapple is destroyed
+        -- Restore and show magazine when grapple is destroyed (fallback)
         if self.parentGun.Magazine then
             self.parentGun.Magazine.RoundCount = 1 -- Restore to 1 round when grapple returns
             self.parentGun.Magazine.Scale = 1 -- Make magazine visible again
-            Logger.debug("Grapple Destroy() - Magazine restored and made visible")
+            Logger.debug("Grapple Destroy() - Magazine restored and made visible (fallback)")
         end
     end
 

Data/Base.rte/Devices/Tools/GrappleGun/Scripts/RopeInputController.lua

@@ -537,7 +537,8 @@ function RopeInputController.refreshGunReference(grappleInstance)
     -- Only refresh if we don't have a valid reference
     if grappleInstance.parentGun then
         local success, presetName = pcall(function() return grappleInstance.parentGun.PresetName end)
-        if success and presetName == "Grapple Gun" then
+        local idSuccess, gunID = pcall(function() return grappleInstance.parentGun.ID end)
+        if success and presetName == "Grapple Gun" and idSuccess and gunID and gunID ~= rte.NoMOID then
             Logger.debug("RopeInputController.refreshGunReference() - Current gun reference is valid, no refresh needed")
             return true -- Current reference is fine
         end
@@ -577,18 +578,63 @@ function RopeInputController.refreshGunReference(grappleInstance)
     end
 
     if foundGun and grappleInstance.parentGun then
-        -- Update magazine state for the refreshed gun
-        if grappleInstance.parentGun.Magazine and MovableMan:IsParticle(grappleInstance.parentGun.Magazine) then
-            local mag = ToMOSParticle(grappleInstance.parentGun.Magazine)
-            mag.RoundCount = 0 -- Keep showing as "fired"
-            mag.Scale = 0 -- Keep hidden while grapple is active
-            Logger.debug("RopeInputController.refreshGunReference() - Updated magazine state for refreshed gun")
+        -- Test if we can actually access the gun's properties
+        local testSuccess, testID = pcall(function() return grappleInstance.parentGun.ID end)
+        if testSuccess and testID and testID ~= rte.NoMOID then
+            -- Update magazine state for the refreshed gun
+            local magSuccess, magazine = pcall(function() return grappleInstance.parentGun.Magazine end)
+            if magSuccess and magazine and MovableMan:IsParticle(magazine) then
+                local mag = ToMOSParticle(magazine)
+                mag.RoundCount = 0 -- Keep showing as "fired"
+                mag.Scale = 0 -- Keep hidden while grapple is active
+                Logger.debug("RopeInputController.refreshGunReference() - Updated magazine state for refreshed gun")
+            end
+            return true
+        else
+            Logger.warn("RopeInputController.refreshGunReference() - Found gun but cannot access its properties")
+            grappleInstance.parentGun = nil
+            return false
         end
-        return true
     end
 
     Logger.warn("RopeInputController.refreshGunReference() - Could not find any grapple gun")
     return false
 end
 
+-- Restore magazine state when grapple is being destroyed
+function RopeInputController.restoreMagazineState(grappleInstance)
+    if not grappleInstance.parentGun then
+        Logger.debug("RopeInputController.restoreMagazineState() - No parent gun to restore")
+        -- Try to find gun one more time for restoration
+        if RopeInputController.refreshGunReference(grappleInstance) then
+            Logger.debug("RopeInputController.restoreMagazineState() - Found gun during restoration attempt")
+        else
+            return false
+        end
+    end
+    
+    -- Don't call refreshGunReference again if we already have a gun reference
+    -- Test the gun reference directly
+    local success, gunID = pcall(function() return grappleInstance.parentGun.ID end)
+    if success and gunID and gunID ~= rte.NoMOID then
+        Logger.info("RopeInputController.restoreMagazineState() - Restoring magazine state for gun (ID: %d)", gunID)
+        
+        -- Restore magazine visibility and ammo count
+        local magSuccess, magazine = pcall(function() return grappleInstance.parentGun.Magazine end)
+        if magSuccess and magazine and MovableMan:IsParticle(magazine) then
+            local mag = ToMOSParticle(magazine)
+            mag.RoundCount = 1 -- Restore ammo
+            mag.Scale = 1 -- Make magazine visible again
+            Logger.info("RopeInputController.restoreMagazineState() - Magazine restored (visible, ammo: 1)")
+            return true
+        else
+            Logger.warn("RopeInputController.restoreMagazineState() - No magazine found to restore")
+        end
+    else
+        Logger.warn("RopeInputController.restoreMagazineState() - Gun ID invalid or inaccessible")
+    end
+    
+    return false
+end
+
 return RopeInputController