LimbPath.cpp - fix debug line drawing #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Debug draws in LimbPath.cpp don't take use the `targetPos` function argument and end up rendering wrong. If only there was a compiler setting or something to find unused function arguments... :v
Contributor
|
Huh. I could've sworn that this worked, at least at some point. Maybe with the changes to render direct-to-screen this fucked up. Nice catch, anyways! |
Causeless
merged commit 39eef65
into
cortex-command-community:development
0 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debug draws in LimbPath.cpp don't take use the
targetPosfunction argument and end up rendering wrong.If only there was a compiler setting or something to find unused function arguments... :v
Before this patch:
tmp.8KXhjEqS6B.mp4
After this patch:
tmp.4VFL1ESkKe.mp4
The importance of this is probably "who cares", but at at least the squiggles aren't going to be all over the place with full debug mode now lmao