-
Notifications
You must be signed in to change notification settings - Fork 27
fix CI for Windows #233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix CI for Windows #233
Conversation
what ok give me a minute ok |
|
Oh, understandable.
HECK! |
guhhhhhhhhhhhhhhhhhhhhhhhh this needs more effort i guess |
|
ALL GREEN MOTHERFUCKER ✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅✅ edit: sorry, got carried away all green though ✅✅✅✅ |
HeliumAnt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Funky, usually it's the linux that finds these things. Good catch!
|
✅ |
230d38b
into
cortex-command-community:development
File
Entity.husesstd::mutexbut never actually does#include <mutex>.As far as I can tell, it just happened by chance that:
# include <bits/std_mutex.h>is written in file/usr/include/c++/15.2.1/bits/atomic_wait.hfrom the GNU C++ library implementation/usr/include/c++/15.2.1/bits/atomic_base.h/usr/include/c++/15.2.1/bits/shared_ptr_atomic.h/usr/include/c++/15.2.1/memory<memory>bySource/System/Reader.hSource/System/Serializable.hSource/System/Entity.h...But of course, I assume GNU C++ library is not used by Microsoft's compiler, and files that they do have likely don't end up including mutex.
So, just, include the mutex where it's used.