Replace broken settings dropdown with a settings window

Author: MyNameIsTrez

Python/gui/checkbox_button_menu.py

@@ -7,8 +7,7 @@
 from Python import convert
 from Python import warnings
 
-from Python.gui import gui_layout
-from Python.gui import checkbox_button_menu
+from Python.gui import gui_windows
 
 
 def init_window_theme():
@@ -21,53 +20,43 @@ def init_window_theme():
 	sg.theme_button_color((sg.theme_text_color(), "#2a3948"))
 
 
-def init_window():
+def init_settings():
 	sg.user_settings_filename(filename="settings.json", path=".")
 
 	if not os.path.isfile(sg.user_settings_filename()):
 		sg.Popup("This is a tool that allows you to convert legacy (old) mods to the latest version of CCCP. You can get more information from the GitHub repo or the Discord server by clicking the corresponding icons.", title="Welcome screen", custom_text=" OK ")
 
-	# set_default_settings(window)
-
 	cfg.sg = sg
 
 	warnings.load_conversion_and_warning_rules() # TODO: Why is this called in this GUI function?
 
-	window = sg.Window(
-		f"Legacy Mod Converter {cfg.CONVERTER_VERSION} for CCCP {cfg.GAME_VERSION}",
-		gui_layout.get_layout(),
-		icon=utils.path("Media/legacy-mod-converter.ico"),
-		font=("Helvetica", 16),
-		finalize=True
-	)
-
-	set_default_settings(window)
-
-	cfg.progress_bar = window["PROGRESS_BAR"]
+	set_default_settings()
 
-	# window.finalize()
 
-	return window
+def set_default_settings():
+	play_finish_sound_setting = sg.user_settings_get_entry("play_finish_sound")
+	sg.user_settings_set_entry("play_finish_sound", True if play_finish_sound_setting == None else play_finish_sound_setting)
 
 
-def set_default_settings(window):
-	if sg.user_settings_get_entry("play_finish_sound") == None:
-		checkbox_button_menu.handle_button_press(window, "SETTINGS", "Play finish sound", cfg.USER_SETTINGS_BUTTON_MAPPINGS)
+def run_window():
+	main_window = gui_windows.get_main_window()
+	settings_window = None
 
+	cfg.progress_bar = main_window["PROGRESS_BAR"]
 
-def run_window(window):
 	valid_cccp_path = True if sg.user_settings_get_entry("cccp_folder") else False
 
 	while True:
-		event, values = window.read()
+		window, event, values = sg.read_all_windows()
 
 		if event == "Exit" or event == sg.WIN_CLOSED:
 			window.close()
-			break
+			if window == main_window:
+				break
+			if window == settings_window:
+				settings_window = None
 
-		# print(event, values)
-
-		if event == "CCCP_FOLDER":
+		elif event == "CCCP_FOLDER":
 			cccp_folder = values[event]
 			if Path(cccp_folder).exists():
 				valid_cccp_path = True
@@ -81,9 +70,12 @@ def run_window(window):
 				valid_cccp_path = False
 				window[event](background_color = cfg.NO_PATH_SET_COLOR)
 
-		elif event == "SETTINGS":
-			selected_button_name = values[event]
-			checkbox_button_menu.handle_button_press(window, event, selected_button_name, cfg.USER_SETTINGS_BUTTON_MAPPINGS)
+		elif event == "LAUNCH_SETTINGS_WINDOW" and settings_window == None:
+			settings_window = gui_windows.get_settings_window()
+
+		elif event in ("SKIP_CONVERSION", "OUTPUT_ZIPS", "PLAY_FINISH_SOUND"):
+			value = values[event]
+			sg.user_settings_set_entry(event.lower(), value)
 
 		elif event == "CONVERT":
 			if valid_cccp_path: