There will no longer be misleading PlaySound warnings that the user supposedly would have to manually fix.

Author: MyNameIsTrez

ConversionRules/Warnings.json

@@ -1,3 +1,3 @@
 {
-	"PlaySound": "No longer supported. Create a SoundContainer with CreateSoundContainer in the appropriate Create function.",
+	"thisisplaceholdertext": "peepeepoopoo",
 }

Media/cclmc-icon.ico renamed to Media/cclmc.ico

@@ -1,4 +1,4 @@
-import os, time, shutil, math, sys, zipfile, json, pathlib, webbrowser
+import os, sys, time, shutil, math, zipfile, json, pathlib, webbrowser
 from pathlib import Path
 from jsoncomment import JsonComment
 from playsound import playsound
@@ -25,14 +25,11 @@ def resource_path(relative_path):
 	return os.path.join(os.path.abspath("."), relative_path)
 
 
-finishSoundPath = resource_path("Media/finish.wav")
-
-
 # If an exe executes this program then sys is frozen.
 output_folder = ".." if getattr(sys, 'frozen', False) else "Output"
 
 
-def	load_conversion_and_warning_rules():
+def load_conversion_and_warning_rules():
 	json_parser = JsonComment(json)
 
 	json_files_found = 0
@@ -93,7 +90,7 @@ def convert():
 
 	elapsed = math.floor(time.time() - time_start)
 	if cfg.sg.user_settings_get_entry("play_finish_sound"):
-		playsound(finishSoundPath)
+		playsound(resource_path("Media/finish.wav"))
 	print("Finished in {} {}".format(elapsed, pluralize("second", elapsed)))
 
 
@@ -143,32 +140,35 @@ def process_files(input_subfiles, input_subfolder_path, output_subfolder, input_
 
 
 def create_converted_file(input_file_path, output_file_path, input_folder_path):
-	try: # TODO: Figure out why this try/except is necessary and why it doesn't check for an error type.
-		with open(input_file_path, "r") as file_in:
-			with open(output_file_path, "w") as file_out:
-				all_lines_list = []
-				file_path = os.path.relpath(input_file_path, input_folder_path)
+	# try: # TODO: Figure out why this try/except is necessary and why it doesn't check for an error type.
+	with open(input_file_path, "r") as file_in:
+		with open(output_file_path, "w") as file_out:
+			all_lines_list = []
+			file_path = os.path.relpath(input_file_path, input_folder_path)
 
-				line_number = 0
-				for line in file_in:
-					line_number += 1
+			line_number = 0
+			for line in file_in:
+				line_number += 1
 
-					if warnings_available:
-						for old_str, new_str in warning_rules.items():
-							if old_str in line:
-								warnings.append("'{}' line {}: {} -> {}".format(file_path, line_number, old_str, new_str))
+				if warnings_available:
+					regex_rules.playsound_warning(line, file_path, line_number, warnings)
 
-					all_lines_list.append(line)
+					for old_str, new_str in warning_rules.items():
+						if old_str in line:
+							print(old_str, new_str)
+							warnings.append("'{}' line {}: {} -> {}".format(file_path, line_number, old_str, new_str))
 
-				all_lines = "".join(all_lines_list)
+				all_lines_list.append(line)
 
-				for old_str, new_str in conversion_rules.items():
-					all_lines = all_lines.replace(old_str, new_str)
+			all_lines = "".join(all_lines_list)
 
-				all_lines = regex_rules.regex_replace(all_lines)
-				file_out.write(regex_rules.regex_replace_bmps_and_wavs(all_lines))
-	except:
-		shutil.copyfile(input_file_path, output_file_path)
+			for old_str, new_str in conversion_rules.items():
+				all_lines = all_lines.replace(old_str, new_str)
+
+			all_lines = regex_rules.regex_replace(all_lines)
+			file_out.write(regex_rules.regex_replace_bmps_and_wavs(all_lines))
+	# except:
+	# 	shutil.copyfile(input_file_path, output_file_path)
 
 
 def warnings_popup():

Python/convert.py

@@ -45,15 +45,14 @@ def init_window():
 			sg.FolderBrowse()
 		],
 		[
-			sg.ProgressBar(100, size=(23.9, 20), key="-PROGRESS BAR-"),
+			sg.ProgressBar(999, size=(23.9, 20), key="-PROGRESS BAR-"),
 			sg.Button("Convert", key="-CONVERT-")
 		]
 		], title="Convert Mods")]
 	]
 
 	play_finish_sound_setting = sg.user_settings_get_entry("play_finish_sound")
 	sg.user_settings_set_entry("play_finish_sound", True if play_finish_sound_setting == None else play_finish_sound_setting)
-	# print(sg.DEFAULT_FONT)
 
 	options_column = [
 		[sg.Frame(layout=[
@@ -86,7 +85,7 @@ def init_window():
 	cfg.sg = sg
 	convert.load_conversion_and_warning_rules()
 
-	window = sg.Window("Legacy Mod Converter", layout, icon=resource_path("Media/cclmc-icon.ico"))
+	window = sg.Window("Legacy Mod Converter", layout, icon=resource_path("Media/cclmc.ico"))
 	cfg.progress_bar = window["-PROGRESS BAR-"]
 
 	return window

Python/gui.py

@@ -78,4 +78,12 @@ def regex_replace_bmps_and_wavs(all_lines):
 	all_lines = specific_replace(all_lines, regex_use_capture, False, "base\.rte(.*?)\.bmp", "Base.rte{}.png")
 	all_lines = specific_replace(all_lines, regex_use_capture, False, "Base\.rte(.*?)\.wav", "Base.rte{}.flac")
 	all_lines = specific_replace(all_lines, regex_use_capture, False, "base\.rte(.*?)\.wav", "Base.rte{}.flac")
-	return all_lines
+	return all_lines
+
+
+def playsound_warning(line, file_path, line_number, warnings):
+	pattern = "PlaySound(.*)"
+	message = "No longer supported. Create a SoundContainer with CreateSoundContainer in the appropriate Create function."
+	matches = re.findall(pattern, line)
+	if len(matches) > 0 and matches[0].count(",") > 2:
+		warnings.append("'{}' line {}: {} -> {}".format(file_path, line_number, pattern, message))

Python/regex_rules.py

@@ -7,10 +7,10 @@ This project automates ***most*** of the conversion work required to convert the
 ## Getting started
 Download the [***Legacy Mod Converter***](https://www.mediafire.com/file/cl3vfatqkoqmop1/Legacy+Mod+Converter.exe/file) program. Create a new folder and put your legacy mods that you want to convert in it. Run the Legacy Mod Converter program.
 
-If you get a "`Microsoft Defender SmartScreen prevented an unrecognized app from starting. Running this app might put your PC at risk.`" popup message when trying to run the program you should press `More info` and then `Run anyway`.
-
 <p align="center"><img src="Media/cclmc-screenshot.png" alt="Legacy Mod Converter screenshot"></p>
 
+If you get a "`Microsoft Defender SmartScreen prevented an unrecognized app from starting. Running this app might put your PC at risk.`" popup message when trying to run the program you should press `More info` and then `Run anyway`.
+
 ## Disclaimer
 This program will do most of the conversion work for you, but some conversion steps are too hard to automate, so it's likely that `CCCP` will still crash or print errors in the console. If this happens you'll have to manually fix these issues in the legacy mod folder. If you want to properly fix these errors then you should download this repository and follow the instructions below so you can add your own conversion cases to `conversion_rules.py`.
 

README.md

@@ -1,5 +1,5 @@
 # Run manually: python main.py
-# Build EXE for CCCP: pyinstaller --noconsole --onefile --icon=Media/cclmc-icon.ico --add-data="Media/github-icon.png;Media" --add-data="Media/discord-icon.png;Media" --add-data="Media/finish.wav;Media" --name="Legacy Mod Converter" main.py
+# Build EXE: pyinstaller --noconsole --onefile --icon="Media/cclmc.ico" --add-data="Media/github-icon.png;Media" --add-data="Media/discord-icon.png;Media" --add-data="Media/finish.wav;Media" --name="Legacy Mod Converter" main.py
 
 from Python import gui