Travis windows (#46)

* yaml -> yml
* travis
* node version
* Restore clocks in tests
* Ensure files created before test
* Added badge

Author: k1o0

.travis.yaml

@@ -0,0 +1,11 @@
+language: node_js
+node_js: 12
+env:
+  - NODE_ENV=test
+jobs:
+  include:
+    - os: windows
+      env: NODE_ENV=test DOTENV_CONFIG_PATH=.\\test\\fixtures\\.env.test
+    - os: linux
+      env: NODE_ENV=test DOTENV_CONFIG_PATH=./test/fixtures/.env.test
+

.travis.yml

@@ -1,4 +1,5 @@
 # MATLAB-ci
+[![Build Status](https://travis-ci.com/cortex-lab/matlab-ci.svg?branch=master)](https://travis-ci.com/cortex-lab/matlab-ci)
 
 A small set of modules written in Node.js for running automated tests of MATLAB code in response to GitHub events.  Also submits code coverage to the Coveralls API.
 

README.md

@@ -4,7 +4,7 @@
   "description": "A small set of modules written in Node.js for running automated tests of MATLAB and Python code in response to GitHub events.  Also submits code coverage to the Coveralls API.",
   "main": "main.js",
   "scripts": {
-    "test": "NODE_ENV=test DOTENV_CONFIG_PATH=.\\\\test\\\\fixtures\\\\.env.test mocha -r dotenv/config ./test --recursive --reporter spec",
+    "test": "mocha -r dotenv/config ./test",
     "start": "node -r dotenv/config main.js"
   },
   "repository": {
@@ -41,12 +41,5 @@
   },
   "engines": {
     "node": ">=12.19.0"
-  },
-  "mocha": {
-    "env": {
-      "dotenv_config_path": "./test/fixtures/.env.test",
-      "NODE_ENV": "test"
-    },
-    "require": "dotenv/config"
   }
 }

package.json

@@ -50,7 +50,7 @@ class Queue extends EventEmitter {
     // generate 16 digit job id
     let d = Date.now().toString()
     let r = Math.floor(Math.random() * 1000).toString()
-    let id = Number(r.padStart(3, '0').concat(d))
+    let id = Number(r.padStart(3, '0') + d)
     this.pile.push(new Job(id, data)); // add to bottom of pile
     console.log('Job added (' + this.pile.length + ' on pile)')
     this.next(); // Start next job if idle

queue.js

@@ -132,7 +132,6 @@ srv.get(`/${ENDPOINT}/records/:id`, function (req, res) {
       id: req.params.id
    };
    let endpoint = `GET /repos/:owner/:repo/${isSHA ? 'commits' : 'branches'}/:id`;
-   log('request to endpoint %s', endpoint);
    request(endpoint, data)
       .then(response => {
          let id = isSHA ? response.data.sha : response.data.commit.sha;

serve.js

@@ -98,7 +98,7 @@ describe('Test updateJobFromRecord:', function() {
 describe('Test startJobTimer:', function() {
    var clock;
 
-    beforeEach(function () {
+    before(function () {
         clock = sinon.useFakeTimers();
     });
 

test/lib.test.js

@@ -39,7 +39,7 @@ describe('Test Queue constructor:', function() {
         assert.strictEqual(this.Q.pile.length, 2, 'failed to add more than one job')
         let id = this.Q.pile[0].id
         let isInt16 = Number.isInteger(id) && id.toString().length === 16
-        assert(isInt16, 'unexpected id')
+        assert(isInt16, `unexpected id ${id}`)
 
         // Check the set is unique
         var ids = this.Q.pile.map((job) => { return job.id; })

test/queue.test.js

@@ -46,14 +46,14 @@ describe('setAccessToken', () => {
 
    before(function () {
       expiry.setTime(expiry.getTime() + 60e3);  // 60s in the future
-   });
-
-   beforeEach(function() {
       // https://runkit.com/gr2m/reproducable-jwt
       clock = sinon.useFakeTimers({
          now: 0,
          toFake: ['Date']
       });
+   });
+
+   beforeEach(function() {
       // Mock for App.installationAccessToken
       scope = nock('https://api.github.com', {
          reqheaders: {
@@ -133,11 +133,8 @@ describe('setAccessToken', () => {
       });
    });
 
-   afterEach(function() {
-      clock.restore();
-   });
-
    after(async function() {
+      clock.restore();
       await resetToken();
    })
 });
@@ -571,25 +568,26 @@ describe('records endpoint', () => {
  */
 describe('coverage endpoint', () => {
 
-   before(function() {
+   before(function(done) {
       let reportsDir = path.join(config.dataPath, 'reports', SHA);
-      fs.mkdir(reportsDir, { recursive: true }, (err) => {
+      fs.mkdir(reportsDir, { recursive: true }, async (err) => {
          if (err) throw err;
-         fs.writeFile(path.join(reportsDir, 'foobar.log'), '', (err) => { if (err) throw err; })
-         fs.writeFile(path.join(reportsDir, 'index.html'), '', (err) => { if (err) throw err; })
+         await fs.writeFile(path.join(reportsDir, 'foobar.log'), '', (err) => { if (err) throw err; })
+         await fs.writeFile(path.join(reportsDir, 'index.html'), '', (err) => { if (err) throw err; })
+         done()
       });
    })
 
    it('expect root not found', (done) => {
       request(srv)
          .get(`/${ENDPOINT}/coverage/`)  // trailing slash essential
          .expect(404)
-         .end(function (err, res) {
+         .end(err => {
             err? done(err) : done();
          });
    });
 
-   it('expect dir served found', (done) => {
+   it('expect dir to be served', (done) => {
       request(srv)
          .get(`/${ENDPOINT}/coverage/${SHA}/`)  // trailing slash essential
          .expect(200)
@@ -718,12 +716,15 @@ describe('srv github/', () => {
    var scope;  // Our server mock
    var clock;  // Our clock mock for replicable JWT
 
-   beforeEach(function() {
+   before(function() {
       // https://runkit.com/gr2m/reproducable-jwt
       clock = sinon.useFakeTimers({
          now: 0,
          toFake: ['Date']
       });
+   });
+
+   beforeEach(function() {
       // Mock for App.installationAccessToken
       scope = nock('https://api.github.com', {
          reqheaders: {
@@ -771,4 +772,8 @@ describe('srv github/', () => {
          });
    });
 
+   after(function () {
+      clock.restore();
+   });
+
 });