tree-kill called after calling kill

Author: k1o0

CHANGELOG.md

@@ -20,6 +20,7 @@
  - preparing the environment may be optional
  - errors during test function are now saved into test record db
  - new config options (see readme)
+ - kill child processes in job timer
 
 
 ## [1.2.0]

lib.js

@@ -245,13 +245,10 @@ function startJobTimer(job, kill_children=false) {
    const timeout = config.timeout || 8*60000;  // How long to wait for the tests to run
    return setTimeout(() => {
       console.log('Max test time exceeded');
-      if (kill_children) {
-         log('Killing all processes');
-         kill(job.data.process.pid);
-      } else {
-         log('Ending test process');
-         job.data.process.kill();
-      }
+      log(kill_children? 'Killing all processes' : 'Ending test process');
+      let pid = job.data.process.pid;
+      job.data.process.kill();
+      if (kill_children) { kill(pid); }
    }, timeout);
 }
 

test/lib.test.js

@@ -118,6 +118,7 @@ describe('Test startJobTimer:', function() {
         // and kill it.  Should be relatively consistent across platforms.
         const cmd = 'ping 127.0.0.1 -n 6 > nul';
         const childProcess = cp.exec(cmd, () => { done(); });
+        childProcess.kill = () => {};  // nop
         const job = { data: {process: childProcess} };
         lib.startJobTimer(job, true);
         // Skip to the end...