Skip to content

Commit 6715ea8

Browse files
fix: handle 409 Already evaluating in trigger-evaluation test
The trigger-evaluation command can return either: - Success message when evaluation is triggered - 409 Conflict when scorecard is already being evaluated Both are valid outcomes and the test should accept either. Updates test assertion to accept both success and 409 responses.
1 parent 3d467f6 commit 6715ea8

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

tests/test_scorecards.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,10 @@ def test_scorecards():
2727
# cannot rely on a scorecard evaluation being complete, so not performing any validation
2828
cli(["scorecards", "next-steps", "-s", "cli-test-scorecard", "-t", "cli-test-service"])
2929

30-
# Test trigger-evaluation command
30+
# Test trigger-evaluation command (accepts both success and 409 Already evaluating)
3131
response = cli(["scorecards", "trigger-evaluation", "-s", "cli-test-scorecard", "-e", "cli-test-service"], return_type=ReturnType.STDOUT)
32-
assert "Scorecard evaluation triggered successfully" in response, "Should receive success message when triggering evaluation"
32+
assert ("Scorecard evaluation triggered successfully" in response or "Already evaluating scorecard" in response), \
33+
"Should receive success message or 409 Already evaluating error"
3334

3435
# cannot rely on a scorecard evaluation being complete, so not performing any validation
3536
#response = cli(["scorecards", "scores", "-s", "cli-test-scorecard", "-t", "cli-test-service"])

0 commit comments

Comments
 (0)