Skip to content

Commit 68bbc4a

Browse files
friedrichgfriedrichg
authored
Enable memcached by default and fix discovering instances (#551)
* Enable memcached by default and fix discovering instances Signed-off-by: Friedrich Gonzalez <[email protected]> * fix docs Signed-off-by: Friedrich Gonzalez <[email protected]> * fix docs Signed-off-by: Friedrich Gonzalez <[email protected]> --------- Signed-off-by: Friedrich Gonzalez <[email protected]>
1 parent 706f190 commit 68bbc4a

File tree

3 files changed

+22
-8
lines changed

3 files changed

+22
-8
lines changed

‎CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,12 @@
22

33
## master / unreleased
44

5+
* [CHANGE] Memcacheds are now enabled by default #551
56
* [CHANGE] Change default config: distributors, rulers, queriers, query-frontend, nginx and compactors can be disrupted until 30%
67
* [CHANGE] Remove startup probes from compactors from default values. It's not recommended in general #542
78
* [CHANGE] Use default value for num_tokens in ingester configuration #544
89
* [DEPENDENCY] Update kiwigrid/k8s-sidecar docker tag to v1.30.5 #531
10+
* [BUGFIX] fix discovering memcached instances #551
911

1012
## 2.6.0 / 2025-05-07
1113

‎README.md

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -383,41 +383,45 @@ Kubernetes: `^1.19.0-0`
383383
| memberlist.&ZeroWidthSpace;service.&ZeroWidthSpace;annotations | object | `{}` | |
384384
| memberlist.&ZeroWidthSpace;service.&ZeroWidthSpace;labels | object | `{}` | |
385385
| memcached-blocks-index.&ZeroWidthSpace;architecture | string | `"high-availability"` | |
386-
| memcached-blocks-index.&ZeroWidthSpace;enabled | bool | `false` | Enables support for block index caching |
386+
| memcached-blocks-index.&ZeroWidthSpace;enabled | bool | `true` | Enables support for block index caching |
387387
| memcached-blocks-index.&ZeroWidthSpace;extraEnvVars[0] | object | `{"name":"MEMCACHED_CACHE_SIZE","value":"1024"}` | MEMCACHED_CACHE_SIZE is the amount of memory allocated to memcached for object storage |
388388
| memcached-blocks-index.&ZeroWidthSpace;extraEnvVars[1] | object | `{"name":"MEMCACHED_MAX_CONNECTIONS","value":"1024"}` | MEMCACHED_MAX_CONNECTIONS is the maximum number of simultaneous connections to the memcached service |
389389
| memcached-blocks-index.&ZeroWidthSpace;extraEnvVars[2] | object | `{"name":"MEMCACHED_THREADS","value":"4"}` | MEMCACHED_THREADS is the number of threads to use when processing incoming requests. By default, memcached is configured to use 4 concurrent threads. The threading improves the performance of storing and retrieving data in the cache, using a locking system to prevent different threads overwriting or updating the same values. |
390390
| memcached-blocks-index.&ZeroWidthSpace;metrics.&ZeroWidthSpace;enabled | bool | `true` | |
391391
| memcached-blocks-index.&ZeroWidthSpace;metrics.&ZeroWidthSpace;serviceMonitor.&ZeroWidthSpace;enabled | bool | `false` | |
392392
| memcached-blocks-index.&ZeroWidthSpace;replicaCount | int | `2` | |
393393
| memcached-blocks-index.&ZeroWidthSpace;resources | object | `{}` | |
394+
| memcached-blocks-index.&ZeroWidthSpace;service.&ZeroWidthSpace;clusterIP | string | `"None"` | |
394395
| memcached-blocks-metadata.&ZeroWidthSpace;architecture | string | `"high-availability"` | |
395-
| memcached-blocks-metadata.&ZeroWidthSpace;enabled | bool | `false` | Enables support for block metadata caching |
396+
| memcached-blocks-metadata.&ZeroWidthSpace;enabled | bool | `true` | Enables support for block metadata caching |
396397
| memcached-blocks-metadata.&ZeroWidthSpace;extraEnvVars[0] | object | `{"name":"MEMCACHED_CACHE_SIZE","value":"1024"}` | MEMCACHED_CACHE_SIZE is the amount of memory allocated to memcached for object storage |
397398
| memcached-blocks-metadata.&ZeroWidthSpace;extraEnvVars[1] | object | `{"name":"MEMCACHED_MAX_CONNECTIONS","value":"1024"}` | MEMCACHED_MAX_CONNECTIONS is the maximum number of simultaneous connections to the memcached service |
398399
| memcached-blocks-metadata.&ZeroWidthSpace;extraEnvVars[2] | object | `{"name":"MEMCACHED_THREADS","value":"4"}` | MEMCACHED_THREADS is the number of threads to use when processing incoming requests. By default, memcached is configured to use 4 concurrent threads. The threading improves the performance of storing and retrieving data in the cache, using a locking system to prevent different threads overwriting or updating the same values. |
399400
| memcached-blocks-metadata.&ZeroWidthSpace;metrics.&ZeroWidthSpace;enabled | bool | `true` | |
400401
| memcached-blocks-metadata.&ZeroWidthSpace;metrics.&ZeroWidthSpace;serviceMonitor.&ZeroWidthSpace;enabled | bool | `false` | |
401402
| memcached-blocks-metadata.&ZeroWidthSpace;replicaCount | int | `2` | |
402403
| memcached-blocks-metadata.&ZeroWidthSpace;resources | object | `{}` | |
404+
| memcached-blocks-metadata.&ZeroWidthSpace;service.&ZeroWidthSpace;clusterIP | string | `"None"` | |
403405
| memcached-blocks.&ZeroWidthSpace;architecture | string | `"high-availability"` | |
404-
| memcached-blocks.&ZeroWidthSpace;enabled | bool | `false` | Enables support for block caching |
406+
| memcached-blocks.&ZeroWidthSpace;enabled | bool | `true` | Enables support for block caching |
405407
| memcached-blocks.&ZeroWidthSpace;extraEnvVars[0] | object | `{"name":"MEMCACHED_CACHE_SIZE","value":"1024"}` | MEMCACHED_CACHE_SIZE is the amount of memory allocated to memcached for object storage |
406408
| memcached-blocks.&ZeroWidthSpace;extraEnvVars[1] | object | `{"name":"MEMCACHED_MAX_CONNECTIONS","value":"1024"}` | MEMCACHED_MAX_CONNECTIONS is the maximum number of simultaneous connections to the memcached service |
407409
| memcached-blocks.&ZeroWidthSpace;extraEnvVars[2] | object | `{"name":"MEMCACHED_THREADS","value":"4"}` | MEMCACHED_THREADS is the number of threads to use when processing incoming requests. By default, memcached is configured to use 4 concurrent threads. The threading improves the performance of storing and retrieving data in the cache, using a locking system to prevent different threads overwriting or updating the same values. |
408410
| memcached-blocks.&ZeroWidthSpace;metrics.&ZeroWidthSpace;enabled | bool | `true` | |
409411
| memcached-blocks.&ZeroWidthSpace;metrics.&ZeroWidthSpace;serviceMonitor.&ZeroWidthSpace;enabled | bool | `false` | |
410412
| memcached-blocks.&ZeroWidthSpace;replicaCount | int | `2` | |
411413
| memcached-blocks.&ZeroWidthSpace;resources | object | `{}` | |
414+
| memcached-blocks.&ZeroWidthSpace;service.&ZeroWidthSpace;clusterIP | string | `"None"` | |
412415
| memcached-frontend.&ZeroWidthSpace;architecture | string | `"high-availability"` | |
413-
| memcached-frontend.&ZeroWidthSpace;enabled | bool | `false` | Enables support for caching queries in the frontend |
416+
| memcached-frontend.&ZeroWidthSpace;enabled | bool | `true` | Enables support for caching queries in the frontend |
414417
| memcached-frontend.&ZeroWidthSpace;extraEnvVars[0] | object | `{"name":"MEMCACHED_CACHE_SIZE","value":"1024"}` | MEMCACHED_CACHE_SIZE is the amount of memory allocated to memcached for object storage |
415418
| memcached-frontend.&ZeroWidthSpace;extraEnvVars[1] | object | `{"name":"MEMCACHED_MAX_CONNECTIONS","value":"1024"}` | MEMCACHED_MAX_CONNECTIONS is the maximum number of simultaneous connections to the memcached service |
416419
| memcached-frontend.&ZeroWidthSpace;extraEnvVars[2] | object | `{"name":"MEMCACHED_THREADS","value":"4"}` | MEMCACHED_THREADS is the number of threads to use when processing incoming requests. By default, memcached is configured to use 4 concurrent threads. The threading improves the performance of storing and retrieving data in the cache, using a locking system to prevent different threads overwriting or updating the same values. |
417420
| memcached-frontend.&ZeroWidthSpace;metrics.&ZeroWidthSpace;enabled | bool | `true` | |
418421
| memcached-frontend.&ZeroWidthSpace;metrics.&ZeroWidthSpace;serviceMonitor.&ZeroWidthSpace;enabled | bool | `false` | |
419422
| memcached-frontend.&ZeroWidthSpace;replicaCount | int | `2` | |
420423
| memcached-frontend.&ZeroWidthSpace;resources | object | `{}` | |
424+
| memcached-frontend.&ZeroWidthSpace;service.&ZeroWidthSpace;clusterIP | string | `"None"` | |
421425
| nginx.&ZeroWidthSpace;affinity | object | `{}` | |
422426
| nginx.&ZeroWidthSpace;annotations | object | `{}` | |
423427
| nginx.&ZeroWidthSpace;autoscaling.&ZeroWidthSpace;behavior | object | `{}` | Ref: https://kubernetes.io/docs/tasks/run-application/horizontal-pod-autoscale/#support-for-configurable-scaling-behavior |

‎values.yaml

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1578,7 +1578,9 @@ compactor:
15781578

15791579
memcached-frontend:
15801580
# -- Enables support for caching queries in the frontend
1581-
enabled: false
1581+
enabled: true
1582+
service:
1583+
clusterIP: None
15821584
architecture: "high-availability"
15831585
replicaCount: 2
15841586
resources: {}
@@ -1601,7 +1603,9 @@ memcached-frontend:
16011603

16021604
memcached-blocks-index:
16031605
# -- Enables support for block index caching
1604-
enabled: false
1606+
enabled: true
1607+
service:
1608+
clusterIP: None
16051609
architecture: "high-availability"
16061610
replicaCount: 2
16071611
resources: {}
@@ -1624,7 +1628,9 @@ memcached-blocks-index:
16241628

16251629
memcached-blocks:
16261630
# -- Enables support for block caching
1627-
enabled: false
1631+
enabled: true
1632+
service:
1633+
clusterIP: None
16281634
architecture: "high-availability"
16291635
replicaCount: 2
16301636
resources: {}
@@ -1647,7 +1653,9 @@ memcached-blocks:
16471653

16481654
memcached-blocks-metadata:
16491655
# -- Enables support for block metadata caching
1650-
enabled: false
1656+
enabled: true
1657+
service:
1658+
clusterIP: None
16511659
architecture: "high-availability"
16521660
replicaCount: 2
16531661
resources: {}

0 commit comments

Comments
 (0)