Skip to content

Commit 808b538

Browse files
authored
Change defaults: Increase pod disruption budget for some stateless components (#546)
Signed-off-by: Friedrich Gonzalez <[email protected]>
1 parent c4dab15 commit 808b538

File tree

3 files changed

+13
-12
lines changed

3 files changed

+13
-12
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
## master / unreleased
44

5+
* [CHANGE] Change default config: distributors, rulers, queriers, query-frontend, nginx and compactors can be disrupted until 30%
56
* [CHANGE] Remove startup probes from compactors from default values. It's not recommended in general #542
67
* [CHANGE] Use default value for num_tokens in ingester configuration #544
78

README.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ Kubernetes: `^1.19.0-0`
190190
| compactor.&ZeroWidthSpace;persistentVolume.&ZeroWidthSpace;storageClass | string | `nil` | compactor data Persistent Volume Storage Class If defined, storageClassName: <storageClass> If set to "-", storageClassName: "", which disables dynamic provisioning If undefined (the default) or set to null, no storageClassName spec is set, choosing the default provisioner. |
191191
| compactor.&ZeroWidthSpace;persistentVolume.&ZeroWidthSpace;subPath | string | `""` | Subdirectory of compactor data Persistent Volume to mount Useful if the volume's root directory is not empty |
192192
| compactor.&ZeroWidthSpace;podAnnotations | object | `{"prometheus.io/port":"8080","prometheus.io/scrape":"true"}` | Pod Annotations |
193-
| compactor.&ZeroWidthSpace;podDisruptionBudget.&ZeroWidthSpace;maxUnavailable | int | `1` | |
193+
| compactor.&ZeroWidthSpace;podDisruptionBudget.&ZeroWidthSpace;maxUnavailable | string | `"30%"` | |
194194
| compactor.&ZeroWidthSpace;podLabels | object | `{}` | Pod Labels |
195195
| compactor.&ZeroWidthSpace;readinessProbe.&ZeroWidthSpace;httpGet.&ZeroWidthSpace;path | string | `"/ready"` | |
196196
| compactor.&ZeroWidthSpace;readinessProbe.&ZeroWidthSpace;httpGet.&ZeroWidthSpace;port | string | `"http-metrics"` | |
@@ -281,7 +281,7 @@ Kubernetes: `^1.19.0-0`
281281
| distributor.&ZeroWidthSpace;nodeSelector | object | `{}` | |
282282
| distributor.&ZeroWidthSpace;persistentVolume.&ZeroWidthSpace;subPath | string | `nil` | |
283283
| distributor.&ZeroWidthSpace;podAnnotations | object | `{"prometheus.io/port":"8080","prometheus.io/scrape":"true"}` | Pod Annotations |
284-
| distributor.&ZeroWidthSpace;podDisruptionBudget.&ZeroWidthSpace;maxUnavailable | int | `1` | |
284+
| distributor.&ZeroWidthSpace;podDisruptionBudget.&ZeroWidthSpace;maxUnavailable | string | `"30%"` | |
285285
| distributor.&ZeroWidthSpace;podLabels | object | `{}` | Pod Labels |
286286
| distributor.&ZeroWidthSpace;readinessProbe.&ZeroWidthSpace;httpGet.&ZeroWidthSpace;path | string | `"/ready"` | |
287287
| distributor.&ZeroWidthSpace;readinessProbe.&ZeroWidthSpace;httpGet.&ZeroWidthSpace;port | string | `"http-metrics"` | |
@@ -458,7 +458,7 @@ Kubernetes: `^1.19.0-0`
458458
| nginx.&ZeroWidthSpace;nodeSelector | object | `{}` | |
459459
| nginx.&ZeroWidthSpace;persistentVolume.&ZeroWidthSpace;subPath | string | `nil` | |
460460
| nginx.&ZeroWidthSpace;podAnnotations | object | `{}` | Pod Annotations |
461-
| nginx.&ZeroWidthSpace;podDisruptionBudget.&ZeroWidthSpace;maxUnavailable | int | `1` | |
461+
| nginx.&ZeroWidthSpace;podDisruptionBudget.&ZeroWidthSpace;maxUnavailable | string | `"30%"` | |
462462
| nginx.&ZeroWidthSpace;podLabels | object | `{}` | Pod Labels |
463463
| nginx.&ZeroWidthSpace;readinessProbe.&ZeroWidthSpace;httpGet.&ZeroWidthSpace;path | string | `"/healthz"` | |
464464
| nginx.&ZeroWidthSpace;readinessProbe.&ZeroWidthSpace;httpGet.&ZeroWidthSpace;port | string | `"http-metrics"` | |
@@ -593,7 +593,7 @@ Kubernetes: `^1.19.0-0`
593593
| querier.&ZeroWidthSpace;nodeSelector | object | `{}` | |
594594
| querier.&ZeroWidthSpace;persistentVolume.&ZeroWidthSpace;subPath | string | `nil` | |
595595
| querier.&ZeroWidthSpace;podAnnotations | object | `{"prometheus.io/port":"8080","prometheus.io/scrape":"true"}` | Pod Annotations |
596-
| querier.&ZeroWidthSpace;podDisruptionBudget.&ZeroWidthSpace;maxUnavailable | int | `1` | |
596+
| querier.&ZeroWidthSpace;podDisruptionBudget.&ZeroWidthSpace;maxUnavailable | string | `"30%"` | |
597597
| querier.&ZeroWidthSpace;podLabels | object | `{}` | Pod Labels |
598598
| querier.&ZeroWidthSpace;readinessProbe.&ZeroWidthSpace;httpGet.&ZeroWidthSpace;path | string | `"/ready"` | |
599599
| querier.&ZeroWidthSpace;readinessProbe.&ZeroWidthSpace;httpGet.&ZeroWidthSpace;port | string | `"http-metrics"` | |
@@ -640,7 +640,7 @@ Kubernetes: `^1.19.0-0`
640640
| query_frontend.&ZeroWidthSpace;nodeSelector | object | `{}` | |
641641
| query_frontend.&ZeroWidthSpace;persistentVolume.&ZeroWidthSpace;subPath | string | `nil` | |
642642
| query_frontend.&ZeroWidthSpace;podAnnotations | object | `{"prometheus.io/port":"8080","prometheus.io/scrape":"true"}` | Pod Annotations |
643-
| query_frontend.&ZeroWidthSpace;podDisruptionBudget.&ZeroWidthSpace;maxUnavailable | int | `1` | |
643+
| query_frontend.&ZeroWidthSpace;podDisruptionBudget.&ZeroWidthSpace;maxUnavailable | string | `"30%"` | |
644644
| query_frontend.&ZeroWidthSpace;podLabels | object | `{}` | Pod Labels |
645645
| query_frontend.&ZeroWidthSpace;readinessProbe.&ZeroWidthSpace;httpGet.&ZeroWidthSpace;path | string | `"/ready"` | |
646646
| query_frontend.&ZeroWidthSpace;readinessProbe.&ZeroWidthSpace;httpGet.&ZeroWidthSpace;port | string | `"http-metrics"` | |
@@ -735,7 +735,7 @@ Kubernetes: `^1.19.0-0`
735735
| ruler.&ZeroWidthSpace;livenessProbe.&ZeroWidthSpace;httpGet.&ZeroWidthSpace;port | string | `"http-metrics"` | |
736736
| ruler.&ZeroWidthSpace;nodeSelector | object | `{}` | |
737737
| ruler.&ZeroWidthSpace;podAnnotations | object | `{"prometheus.io/port":"8080","prometheus.io/scrape":"true"}` | Pod Annotations |
738-
| ruler.&ZeroWidthSpace;podDisruptionBudget.&ZeroWidthSpace;maxUnavailable | int | `1` | |
738+
| ruler.&ZeroWidthSpace;podDisruptionBudget.&ZeroWidthSpace;maxUnavailable | string | `"30%"` | |
739739
| ruler.&ZeroWidthSpace;podLabels | object | `{}` | Pod Labels |
740740
| ruler.&ZeroWidthSpace;readinessProbe.&ZeroWidthSpace;httpGet.&ZeroWidthSpace;path | string | `"/ready"` | |
741741
| ruler.&ZeroWidthSpace;readinessProbe.&ZeroWidthSpace;httpGet.&ZeroWidthSpace;port | string | `"http-metrics"` | |

values.yaml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -416,7 +416,7 @@ distributor:
416416
tolerations: []
417417

418418
podDisruptionBudget:
419-
maxUnavailable: 1
419+
maxUnavailable: 30%
420420

421421
initContainers: []
422422
extraContainers: []
@@ -683,7 +683,7 @@ ruler:
683683
tolerations: []
684684

685685
podDisruptionBudget:
686-
maxUnavailable: 1
686+
maxUnavailable: 30%
687687

688688
initContainers: []
689689
extraContainers: []
@@ -832,7 +832,7 @@ querier:
832832
tolerations: []
833833

834834
podDisruptionBudget:
835-
maxUnavailable: 1
835+
maxUnavailable: 30%
836836

837837
initContainers: []
838838
extraContainers: []
@@ -925,7 +925,7 @@ query_frontend:
925925
tolerations: []
926926

927927
podDisruptionBudget:
928-
maxUnavailable: 1
928+
maxUnavailable: 30%
929929

930930
initContainers: []
931931
extraContainers: []
@@ -1305,7 +1305,7 @@ nginx:
13051305
tolerations: []
13061306

13071307
podDisruptionBudget:
1308-
maxUnavailable: 1
1308+
maxUnavailable: 30%
13091309

13101310
initContainers: []
13111311
extraContainers: []
@@ -1567,7 +1567,7 @@ compactor:
15671567
tolerations: []
15681568

15691569
podDisruptionBudget:
1570-
maxUnavailable: 1
1570+
maxUnavailable: 30%
15711571

15721572
initContainers: []
15731573
extraContainers: []

0 commit comments

Comments
 (0)