You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fix compactor_blocks_retention_period type in extra_small_user (grafana#395)
* Fix `compactor_blocks_retention_period` type in `extra_small_user`
The actual type of `compactor_blocks_retention_period` is `model.Duration`. Which comes
from prometheus `common` package.
The problem is that `model.Duration` have custom JSON unmarshal which treat the incoming
value as string.
https://github.com/prometheus/common/blob/main/model/time.go#L276
So setting it as integer, won't work when unmarshalling with JSON.
NOTE: This won't be an issue for YamlUnmarshal, as it always treating it as string (even
though you put it as integer)
https://github.com/prometheus/common/blob/main/model/time.go#L307
* update CHANGELOG
0 commit comments