Skip to content

Commit c030037

Browse files
authored
Merge pull request grafana#399 from grafana/add-queryEngineConfig
Add queryEngineConfig
2 parents abb0806 + c3627fd commit c030037

File tree

4 files changed

+9
-1
lines changed

4 files changed

+9
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@
5757
* `CortexAlertmanagerInitialSyncFailed`
5858
* [ENHANCEMENT] Add support for Azure storage in Alertmanager configuration. #381
5959
* [ENHANCEMENT] Add support for running Alertmanager in sharding mode. #394
60+
* [ENHANCEMENT] Allow to customize PromQL engine settings via `queryEngineConfig`. #399
6061
* [BUGFIX] Fixed `CortexIngesterHasNotShippedBlocks` alert false positive in case an ingester instance had ingested samples in the past, then no traffic was received for a long period and then it started receiving samples again. #308
6162
* [BUGFIX] Alertmanager: fixed `--alertmanager.cluster.peers` CLI flag passed to alertmanager when HA is enabled. #329
6263
* [BUGFIX] Fixed `CortexInconsistentRuntimeConfig` metric. #335

cortex/config.libsonnet

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@
196196
) else {}
197197
),
198198

199-
// Shared between the Ruler and Querier
199+
// Querier component config (shared between the ruler and querier).
200200
queryConfig: {
201201
'runtime-config.file': '/etc/cortex/overrides.yaml',
202202

@@ -239,6 +239,11 @@
239239
else {}
240240
),
241241

242+
// PromQL query engine config (shared between all services running PromQL engine, like the ruler and querier).
243+
queryEngineConfig: {
244+
// Keep it even if empty, to allow downstream projects to easily configure it.
245+
},
246+
242247
ringConfig: {
243248
'consul.hostname': 'consul.%s.svc.cluster.local:8500' % $._config.namespace,
244249
'ring.prefix': '',

cortex/querier.libsonnet

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
$._config.storageConfig +
99
$._config.blocksStorageConfig +
1010
$._config.queryConfig +
11+
$._config.queryEngineConfig +
1112
$._config.distributorConfig +
1213
{
1314
target: 'querier',

cortex/ruler.libsonnet

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
$._config.storageConfig +
99
$._config.blocksStorageConfig +
1010
$._config.queryConfig +
11+
$._config.queryEngineConfig +
1112
$._config.distributorConfig +
1213
$._config.rulerClientConfig +
1314
$._config.rulerLimitsConfig +

0 commit comments

Comments
 (0)