Fix golangci configuration (#27)

* Fix golangci configuration

- Remove golint and add revive. golint is deprecated
- Also fix goimports local-prefixes

Signed-off-by: Friedrich Gonzalez <[email protected]>

* Fix linting

Signed-off-by: Friedrich Gonzalez <[email protected]>

---------

Signed-off-by: Friedrich Gonzalez <[email protected]>

Author: friedrichg

.golangci.yml

@@ -11,12 +11,12 @@ output:
 linters:
   enable:
     - goimports
-    - golint
+    - revive
     - misspell
     - gofmt
 
 linters-settings:
   errcheck:
     exclude: .errcheck-exclude
   goimports:
-    local-prefixes: "github.com/cortexproject/cortextool"
+    local-prefixes: "github.com/cortexproject/cortex-tools"

cmd/e2ealerting/main.go

@@ -4,9 +4,10 @@ import (
 	"flag"
 	"os"
 
-	"github.com/cortexproject/cortex-tools/pkg/alerting"
 	"github.com/go-kit/log/level"
 
+	"github.com/cortexproject/cortex-tools/pkg/alerting"
+
 	"github.com/cortexproject/cortex/pkg/util/flagext"
 	util_log "github.com/cortexproject/cortex/pkg/util/log"
 	"github.com/prometheus/client_golang/prometheus"

cmd/logtool/main.go

@@ -45,7 +45,7 @@ func main() {
 	for scanner.Scan() {
 		show := false
 		var qt time.Time
-		var dur, len time.Duration
+		var dur, length time.Duration
 		var status, path, query, trace string
 		var err error
 
@@ -99,13 +99,13 @@ func main() {
 							fmt.Println(err, line)
 							continue
 						}
-						len = et.Sub(st)
+						length = et.Sub(st)
 					} else {
 						// Loki queries are nanosecond, simple check to see if it's a second or nanosecond timestamp
 						if st > 9999999999 {
-							len = time.Unix(0, et).Sub(time.Unix(0, st))
+							length = time.Unix(0, et).Sub(time.Unix(0, st))
 						} else {
-							len = time.Unix(et, 0).Sub(time.Unix(st, 0))
+							length = time.Unix(et, 0).Sub(time.Unix(st, 0))
 						}
 
 					}
@@ -132,9 +132,9 @@ func main() {
 				ts = fmt.Sprint(qt.Local())
 			}
 			if *showQuery {
-				fmt.Fprintf(w, "%v\t%v\t%v\t%v\t%v\t%v\t%v\n", ts, trace, len, dur, status, path, query)
+				fmt.Fprintf(w, "%v\t%v\t%v\t%v\t%v\t%v\t%v\n", ts, trace, length, dur, status, path, query)
 			} else {
-				fmt.Fprintf(w, "%v\t%v\t%v\t%v\t%v\t%v\n", ts, trace, len, dur, status, path)
+				fmt.Fprintf(w, "%v\t%v\t%v\t%v\t%v\t%v\n", ts, trace, length, dur, status, path)
 			}
 			//If looking at stdin, flush after every line as someone would only paste one line at a time at the terminal
 			if !isPipe {

pkg/alerting/runner.go

@@ -9,12 +9,13 @@ import (
 	"sync"
 	"time"
 
-	"github.com/cortexproject/cortex-tools/pkg/client"
-	"github.com/cortexproject/cortex-tools/pkg/rules/rwrulefmt"
 	"github.com/go-kit/log"
 	"github.com/go-kit/log/level"
 	"github.com/prometheus/client_golang/prometheus"
 	yaml "gopkg.in/yaml.v3"
+
+	"github.com/cortexproject/cortex-tools/pkg/client"
+	"github.com/cortexproject/cortex-tools/pkg/rules/rwrulefmt"
 )
 
 // Case represents a metric that can be used for exporting, then verified against an Alertmanager webhook

pkg/analyse/ruler.go

@@ -3,10 +3,11 @@ package analyse
 import (
 	"sort"
 
-	"github.com/cortexproject/cortex-tools/pkg/rules/rwrulefmt"
 	"github.com/pkg/errors"
 	"github.com/prometheus/prometheus/promql/parser"
 	log "github.com/sirupsen/logrus"
+
+	"github.com/cortexproject/cortex-tools/pkg/rules/rwrulefmt"
 )
 
 type MetricsInRuler struct {

pkg/bench/query_runner.go

@@ -204,8 +204,8 @@ func (q *queryRunner) executeQuery(ctx context.Context, queryReq query) error {
 	now := time.Now()
 
 	var (
-		queryType string = "instant"
-		status    string = "success"
+		queryType = "instant"
+		status    = "success"
 	)
 	if queryReq.timeRange > 0 {
 		queryType = "range"

pkg/bench/write_client.go

@@ -39,7 +39,7 @@ type writeClient struct {
 }
 
 // newWriteClient creates a new client for remote write.
-func newWriteClient(name string, tenantName string, conf *remote.ClientConfig, logger log.Logger, requestHistogram *prometheus.HistogramVec) (*writeClient, error) {
+func newWriteClient(name string, tenantName string, conf *remote.ClientConfig, _ log.Logger, requestHistogram *prometheus.HistogramVec) (*writeClient, error) {
 	httpClient, err := config_util.NewClientFromConfig(conf.HTTPClientConfig, "bench_write_client", config_util.WithHTTP2Disabled())
 	if err != nil {
 		return nil, err

pkg/chunk/cassandra/storage_client.go

@@ -196,4 +196,4 @@ func (noopConvictionPolicy) AddFailure(err error, host *gocql.HostInfo) bool {
 }
 
 // Implementats gocql.ConvictionPolicy.
-func (noopConvictionPolicy) Reset(host *gocql.HostInfo) {}
+func (noopConvictionPolicy) Reset(_ *gocql.HostInfo) {}

pkg/chunk/migrate/writer/writer.go

@@ -91,7 +91,7 @@ func (w *Writer) Run(ctx context.Context, inChan chan chunk.Chunk) {
 	}
 }
 
-func (w *Writer) writeLoop(ctx context.Context, workerID int, inChan chan chunk.Chunk, errChan chan error) {
+func (w *Writer) writeLoop(ctx context.Context, _ int, inChan chan chunk.Chunk, errChan chan error) {
 	defer w.workerGroup.Done()
 
 	for {

pkg/client/alerts.go

@@ -17,7 +17,7 @@ type configCompat struct {
 }
 
 // CreateAlertmanagerConfig creates a new alertmanager config
-func (r *CortexClient) CreateAlertmanagerConfig(ctx context.Context, cfg string, templates map[string]string) error {
+func (r *CortexClient) CreateAlertmanagerConfig(_ context.Context, cfg string, templates map[string]string) error {
 	payload, err := yaml.Marshal(&configCompat{
 		TemplateFiles:      templates,
 		AlertmanagerConfig: cfg,
@@ -37,7 +37,7 @@ func (r *CortexClient) CreateAlertmanagerConfig(ctx context.Context, cfg string,
 }
 
 // DeleteAlermanagerConfig deletes the users alertmanagerconfig
-func (r *CortexClient) DeleteAlermanagerConfig(ctx context.Context) error {
+func (r *CortexClient) DeleteAlermanagerConfig(_ context.Context) error {
 	res, err := r.doRequest(alertmanagerAPIPath, "DELETE", nil)
 	if err != nil {
 		return err
@@ -49,7 +49,7 @@ func (r *CortexClient) DeleteAlermanagerConfig(ctx context.Context) error {
 }
 
 // GetAlertmanagerConfig retrieves a rule group
-func (r *CortexClient) GetAlertmanagerConfig(ctx context.Context) (string, map[string]string, error) {
+func (r *CortexClient) GetAlertmanagerConfig(_ context.Context) (string, map[string]string, error) {
 	res, err := r.doRequest(alertmanagerAPIPath, "GET", nil)
 	if err != nil {
 		log.Debugln("no alert config present in response")