@@ -456,7 +456,6 @@ func TestParquetGatewayWithBlocksStorageRunningInSingleBinaryMode(t *testing.T)
456456 BlocksStorageFlags (),
457457 AlertmanagerLocalFlags (),
458458 map [string ]string {
459- "-target" : "all,parquet-converter" ,
460459 "-blocks-storage.tsdb.block-ranges-period" : blockRangePeriod .String (),
461460 "-blocks-storage.tsdb.ship-interval" : "1s" ,
462461 "-blocks-storage.bucket-store.sync-interval" : "1s" ,
@@ -502,14 +501,16 @@ func TestParquetGatewayWithBlocksStorageRunningInSingleBinaryMode(t *testing.T)
502501 cluster := e2ecortex .NewCompositeCortexService (cortex1 , cortex2 )
503502 require .NoError (t , s .StartAndWaitReady (cortex1 , cortex2 ))
504503
504+ parquetConverter := e2ecortex .NewParquetConverter ("parquet-converter" , e2ecortex .RingStoreConsul , consul .NetworkHTTPEndpoint (), flags , "" )
505+ require .NoError (t , s .StartAndWaitReady (parquetConverter ))
506+
505507 // Wait until Cortex replicas have updated the ring state.
506508 for _ , replica := range cluster .Instances () {
507- numTokensPerInstance := 512 // Ingesters ring.
508- parquetConverterRingToken := 512 // Parquet converter ring.
509+ numTokensPerInstance := 512 // Ingesters ring.
509510 if testCfg .blocksShardingEnabled {
510511 numTokensPerInstance += 512 * 2 // Store-gateway ring (read both by the querier and store-gateway).
511512 }
512- require .NoError (t , replica .WaitSumMetrics (e2e .Equals (float64 ((parquetConverterRingToken + numTokensPerInstance )* cluster .NumInstances ())), "cortex_ring_tokens_total" ))
513+ require .NoError (t , replica .WaitSumMetrics (e2e .Equals (float64 ((numTokensPerInstance )* cluster .NumInstances ())), "cortex_ring_tokens_total" ))
513514 }
514515
515516 c , err := e2ecortex .NewClient (cortex1 .HTTPEndpoint (), cortex2 .HTTPEndpoint (), "" , "" , "user-1" )
@@ -551,8 +552,7 @@ func TestParquetGatewayWithBlocksStorageRunningInSingleBinaryMode(t *testing.T)
551552 require .NoError (t , cluster .WaitSumMetrics (e2e .Equals (float64 (2 * cluster .NumInstances ())), "cortex_ingester_memory_series_removed_total" ))
552553
553554 // Wait until the parquet-converter convert blocks
554- time .Sleep (time .Second * 5 )
555- require .NoError (t , cluster .WaitSumMetricsWithOptions (e2e .Equals (float64 (2 * cluster .NumInstances ())), []string {"cortex_parquet_converter_blocks_converted_total" }, e2e .WaitMissingMetrics ))
555+ require .NoError (t , parquetConverter .WaitSumMetrics (e2e .Equals (float64 (2 * cluster .NumInstances ())), "cortex_parquet_converter_blocks_converted_total" ))
556556
557557 // Query back the series (1 only in the storage, 1 only in the ingesters, 1 on both).
558558 result , err := c .Query ("series_1" , series1Timestamp )
0 commit comments