Skip to content

Commit 03911b6

Browse files
authored
Fix integration TestSingleBinaryWithMemberlistScaling flaking. (#4361)
This appears to be highlighting an issue - raised as #4360. This change just stops the test flaking until it can be fixed. Signed-off-by: Steve Simpson <[email protected]>
1 parent 733f7de commit 03911b6

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

integration/integration_memberlist_single_binary_test.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -197,6 +197,13 @@ func TestSingleBinaryWithMemberlistScaling(t *testing.T) {
197197
c := instances[i]
198198
instances = instances[:i]
199199
stop.Go(func() error { return s.Stop(c) })
200+
201+
// TODO(#4360): Remove this when issue is resolved.
202+
// Wait until memberlist for all nodes has recognised the instance left.
203+
// This means that we will not gossip tombstones to leaving nodes.
204+
for _, c := range instances {
205+
require.NoError(t, c.WaitSumMetrics(e2e.Equals(float64(len(instances))), "memberlist_client_cluster_members_count"))
206+
}
200207
}
201208
require.NoError(t, stop.Wait())
202209

0 commit comments

Comments
 (0)