Avoid liveness check seg-fault in 'New' state (#6597)

rajagopalanand · web-flow · commit 184d9880fa30 · 2025-02-18T18:33:08.000-08:00
diff --git a/pkg/ruler/ruler.go b/pkg/ruler/ruler.go
@@ -586,6 +586,9 @@ func ownsRuleGroupOrDisable(g *rulespb.RuleGroupDesc, disabledRuleGroups validat
 }
 
 func (r *Ruler) LivenessCheck(_ context.Context, request *LivenessCheckRequest) (*LivenessCheckResponse, error) {
+	if r.lifecycler.ServiceContext() == nil {
+		return nil, errors.New("ruler is not yet ready")
+	}
 	if r.lifecycler.ServiceContext().Err() != nil || r.subservices.IsStopped() {
 		return nil, errors.New("ruler's context is canceled and might be stopping soon")
 	}

Original file line number	Diff line number	Diff line change
`@@ -586,6 +586,9 @@ func ownsRuleGroupOrDisable(g *rulespb.RuleGroupDesc, disabledRuleGroups validat`
`586`	`586`	`}`
`587`	`587`
`588`	`588`	`func (r Ruler) LivenessCheck(_ context.Context, request LivenessCheckRequest) (*LivenessCheckResponse, error) {`
	`589`	`+ if r.lifecycler.ServiceContext() == nil {`
	`590`	`+ return nil, errors.New("ruler is not yet ready")`
	`591`	`+ }`
`589`	`592`	`if r.lifecycler.ServiceContext().Err() != nil \|\| r.subservices.IsStopped() {`
`590`	`593`	`return nil, errors.New("ruler's context is canceled and might be stopping soon")`
`591`	`594`	`}`