Skip to content

Commit 523dde1

Browse files
nous23pstibrany
andauthored
fix querier panics when query exemplars (#4473)
* fix querier panics when query exemplars Signed-off-by: nous23 <[email protected]> * Update CHANGELOG.md Co-authored-by: Peter Štibraný <[email protected]> Signed-off-by: nous23 <[email protected]> Co-authored-by: Peter Štibraný <[email protected]>
1 parent 8250d87 commit 523dde1

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@
5050
* [BUGFIX] Querier: After query-frontend restart, querier may have lower than configured concurrency. #4417
5151
* [BUGFIX] Memberlist: forward only changes, not entire original message. #4419
5252
* [BUGFIX] Memberlist: don't accept old tombstones as incoming change, and don't forward such messages to other gossip members. #4420
53+
* [BUGFIX] Querier: fixed panic when querying exemplars and using `-distributor.shard-by-all-labels=false`. #4473
5354

5455
## 1.10.0 / 2021-08-03
5556

pkg/distributor/query.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ func (d *Distributor) QueryExemplars(ctx context.Context, from, to model.Time, m
5959
}
6060

6161
// We ask for all ingesters without passing matchers because exemplar queries take in an array of array of label matchers.
62-
replicationSet, err := d.GetIngestersForQuery(ctx, nil)
62+
replicationSet, err := d.GetIngestersForQuery(ctx)
6363
if err != nil {
6464
return err
6565
}

0 commit comments

Comments
 (0)