Skip to content

Commit 728cfbe

Browse files
authored
Add metric name to metadata error (#4363)
Signed-off-by: Goutham Veeramachaneni <[email protected]>
1 parent e49102c commit 728cfbe

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

pkg/ingester/user_metrics_metadata.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@ import (
44
"sync"
55
"time"
66

7+
"github.com/prometheus/prometheus/pkg/labels"
8+
79
"github.com/cortexproject/cortex/pkg/cortexpb"
810
"github.com/cortexproject/cortex/pkg/util/validation"
911
)
@@ -49,7 +51,7 @@ func (mm *userMetricsMetadata) add(metric string, metadata *cortexpb.MetricMetad
4951

5052
if err := mm.limiter.AssertMaxMetadataPerMetric(mm.userID, len(set)); err != nil {
5153
validation.DiscardedMetadata.WithLabelValues(mm.userID, perMetricMetadataLimit).Inc()
52-
return makeLimitError(perMetricMetadataLimit, mm.limiter.FormatError(mm.userID, err))
54+
return makeMetricLimitError(perMetricMetadataLimit, labels.FromStrings(labels.MetricName, metric), mm.limiter.FormatError(mm.userID, err))
5355
}
5456

5557
// if we have seen this metadata before, it is a no-op and we don't need to change our metrics.

0 commit comments

Comments
 (0)