Skip to content

Commit 8202062

Browse files
authored
Pass limit to merge serieset for labels API (#6619)
* pass limit to merge serieset Signed-off-by: yeya24 <[email protected]> * update comment Signed-off-by: yeya24 <[email protected]> --------- Signed-off-by: yeya24 <[email protected]>
1 parent 684c90a commit 8202062

File tree

3 files changed

+2
-10
lines changed

3 files changed

+2
-10
lines changed

pkg/ingester/ingester.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1878,7 +1878,7 @@ func (i *Ingester) metricsForLabelMatchersCommon(ctx context.Context, req *clien
18781878
seriesSet := q.Select(ctx, true, hints, matchers...)
18791879
sets = append(sets, seriesSet)
18801880
}
1881-
mergedSet = storage.NewMergeSeriesSet(sets, 0, storage.ChainedSeriesMerge)
1881+
mergedSet = storage.NewMergeSeriesSet(sets, limit, storage.ChainedSeriesMerge)
18821882
} else {
18831883
mergedSet = q.Select(ctx, false, hints, matchersSet[0]...)
18841884
}

pkg/querier/blocks_store_queryable.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -484,9 +484,8 @@ func (q *blocksStoreQuerier) selectSorted(ctx context.Context, sp *storage.Selec
484484
storage.EmptySeriesSet()
485485
}
486486

487-
// TODO(johrry): pass limit when merging.
488487
return series.NewSeriesSetWithWarnings(
489-
storage.NewMergeSeriesSet(resSeriesSets, 0, storage.ChainedSeriesMerge),
488+
storage.NewMergeSeriesSet(resSeriesSets, int(limit), storage.ChainedSeriesMerge),
490489
resWarnings)
491490
}
492491

pkg/querier/blocks_store_queryable_test.go

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -647,20 +647,13 @@ func TestBlocksStoreQuerier_Select(t *testing.T) {
647647
},
648648
limits: &blocksStoreLimitsMock{},
649649
queryLimiter: noOpQueryLimiter,
650-
// TODO (johrry): Update this after passing limit in merge
651650
expectedSeries: []seriesResult{
652651
{
653652
lbls: labels.New(metricNameLabel, series1Label),
654653
values: []valueResult{
655654
{t: minT, v: 1},
656655
{t: minT + 1, v: 2},
657656
},
658-
}, {
659-
lbls: labels.New(metricNameLabel, series2Label),
660-
values: []valueResult{
661-
{t: minT, v: 1},
662-
{t: minT + 1, v: 3},
663-
},
664657
},
665658
},
666659
},

0 commit comments

Comments
 (0)