Skip to content

Commit 8958d59

Browse files
authored
Fix flaky ring consistency test (#6589)
Use 128 tokens instead of 10,000. Use ringDesc when generating testValues and creating a ring of ingesters. Fixes: #6513 Related: #6535 Signed-off-by: Charlie Le <[email protected]>
1 parent 72bfc29 commit 8958d59

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

pkg/ring/ring_test.go

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -574,8 +574,6 @@ func TestRing_Get_Stability(t *testing.T) {
574574
}
575575

576576
func TestRing_Get_Consistency(t *testing.T) {
577-
// Number of tests to run.
578-
const testCount = 10000
579577
g := NewRandomTokenGenerator()
580578

581579
tests := map[string]struct {
@@ -686,10 +684,10 @@ func TestRing_Get_Consistency(t *testing.T) {
686684

687685
for testName, testData := range tests {
688686
t.Run(testName, func(t *testing.T) {
689-
testValues := g.GenerateTokens(NewDesc(), "", "", testCount, true)
687+
ringDesc := &Desc{Ingesters: generateRingInstances(testData.initialInstances, testData.numZones, 128)}
688+
testValues := g.GenerateTokens(ringDesc, "", "", 128, true)
690689
bufDescs, bufHosts, bufZones := MakeBuffersForGet()
691-
for i := 0; i < testCount; i++ {
692-
ringDesc := &Desc{Ingesters: generateRingInstances(testData.initialInstances, testData.numZones, 128)}
690+
for i := 0; i < 128; i++ {
693691
ring := Ring{
694692
cfg: Config{
695693
HeartbeatTimeout: time.Hour,

0 commit comments

Comments
 (0)