Skip to content

Support peakSamples in query frontend response #6181

@yeya24

Description

@yeya24

Is your feature request related to a problem? Please describe.
peakSamples field was supported in Prometheus query response long time ago https://github.com/prometheus/prometheus/pull/10369/files#diff-9e1a49d3ecc79eae504d539895c7621d3f45eef192ddd6192d8b304ffa591864R111.

However, it is not supported yet at Cortex. https://github.com/cortexproject/cortex/blob/master/pkg/querier/tripperware/query.proto#L41

We only have totalQueryableSamples and totalQueryableSamplesPerStep.

Describe the solution you'd like
Modify the query frontend protobuf and add the field. Also implement the merge logic accordingly.

Metadata

Metadata

Assignees

Labels

component/query-frontendgood first issueThese are great first issues. If you are looking for a place to start, start here!

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions