feat: support configurable name validation (legacy or UTF-8 schemes) #6916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 7h3-3mp7y-m4n <[email protected]>
|
I think the test failure is expected. Please see #6733 (comment) |
|
For sure @yeya24 , I'll work on it! |
Signed-off-by: 7h3-3mp7y-m4n <[email protected]>
Signed-off-by: 7h3-3mp7y-m4n <[email protected]>
yeya24
reviewed
Jul 29, 2025
| model.NameValidationScheme = model.UTF8Validation | ||
| } else { | ||
| // nolint:staticcheck // SA1019: using deprecated NameValidationScheme intentionally for legacy validation testing | ||
| model.NameValidationScheme = model.LegacyValidation |
There was a problem hiding this comment.
We shouldn't be modifying model.NameValidationScheme directly in the test case. Let's use the new config we added instead.
|
Hey @7h3-3mp7y-m4n, sorry for the ping. Do you still plan to continue this PR? |
|
Hi @yeya24, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds
name_validation_schemeas a YAML config field and-name.validation-schemeas a CLI flag to configure the metric and label name validation mode. Supports legacy (default) and UTF-8 options.Which issue(s) this PR fixes:
Fixes #6702
Follow Up #6733
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]