Skip to content

fix flaky test TestDiscardedSeriesTracker #7047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix flaky test TestDiscardedSeriesTracker #7047

wants to merge 1 commit into from

Conversation

SungJin1212
Copy link
Member

@SungJin1212 SungJin1212 commented Oct 10, 2025 •
edited
Loading

I have found the test TestDiscardedSeriesTracker is flaky; the logs are:

--- FAIL: TestDiscardedSeriesTracker (0.00s)
    tracker_test.go:114: 
        	Error Trace:	/__w/cortex/cortex/pkg/util/discardedseries/tracker_test.go:114
        	            				/__w/cortex/cortex/pkg/util/discardedseries/tracker_test.go:81
        	Error:      	Not equal: 
        	            	expected: 0
        	            	actual  : 1
        	Test:       	TestDiscardedSeriesTracker
FAIL

How to reproduce

go test -count=100 -race -run TestDiscardedSeriesTracker ./pkg/util/discardedseries

Like #7036, the usersToDelete should be re-initialized for each loop.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

yeya24
yeya24 approved these changes Oct 11, 2025
View reviewed changes
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yeya24 yeya24 yeya24 approved these changes

Assignees

No one assigned

Labels

size/XS type/flaky-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SungJin1212 @yeya24